Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 839
    • Issues 839
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 45
    • Merge Requests 45
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Issues
  • #1732

Closed
Open
Opened 3 weeks ago by Ben Hayward@benhayward.ben
  • Report abuse
  • New issue
Report abuse New issue

(bug): Remind not immediately removed after delete

Summary

A remind not immediately removed after delete.

Steps to reproduce

  1. Make a remind.
  2. Delete it.

Platform information

Chrome (Replicated).

What is the current bug behavior?

Remind not removed until refresh.

What is the expected correct behavior?

After deletion completes, post should be removed.

Relevant logs and/or screenshots

(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's very hard to read otherwise.)

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

Please solve the reCAPTCHA

We want to be sure it is you, please confirm you are not a robot.

Related issues
0

    • Discussion 20
    • Designs 0
    • Ben Hayward @benhayward.ben added Priority::2 - Normal Product::Newsfeed Type::Bug scoped labels 3 weeks ago

      added Priority::2 - Normal Product::Newsfeed Type::Bug scoped labels

    • Nicholas Lewis
      Nicholas Lewis @javanick · 3 weeks ago
      Developer

      This is true for all posted media, not just Reminds

    • Ben Hayward
      Ben Hayward @benhayward.ben · 3 weeks ago
      Developer

      Noted, has not realised this. Will assign to next sprint, may have time this sprint though.

    • Ben Hayward @benhayward.ben assigned to @benhayward.ben 3 weeks ago

      assigned to @benhayward.ben

    • Ben Hayward @benhayward.ben changed milestone to %sprint: Modest Monkey 3 weeks ago

      changed milestone to %sprint: Modest Monkey

    • Ben Hayward @benhayward.ben changed weight to 4 2 weeks ago

      changed weight to 4

    • Ben Hayward @benhayward.ben changed weight to 5 2 weeks ago

      changed weight to 5

    • Ben Hayward @benhayward.ben added Status::InProgress scoped label 1 day ago

      added Status::InProgress scoped label

    • Ben Hayward @benhayward.ben removed Status::InProgress label 1 day ago

      removed Status::InProgress label

    • Ben Hayward @benhayward.ben mentioned in issue #1762 (closed) 1 day ago

      mentioned in issue #1762 (closed)

    • Ben Hayward @benhayward.ben changed milestone to %sprint: Nuanced Numbat 23 hours ago

      changed milestone to %sprint: Nuanced Numbat

    • Mark Harding @markeharding added Sprint::09/11 - Nuanced Numbat scoped label 11 hours ago

      added Sprint::09/11 - Nuanced Numbat scoped label

    • Mark Harding @markeharding removed milestone 10 hours ago

      removed milestone

    • Ben Hayward @benhayward.ben changed weight to 2 7 hours ago

      changed weight to 2

    • Ben Hayward @benhayward.ben changed time estimate to 3h 7 hours ago

      changed time estimate to 3h

    • Ben Hayward @benhayward.ben added Status::InProgress scoped label 50 minutes ago

      added Status::InProgress scoped label

    • Ben Hayward
      Ben Hayward @benhayward.ben · 19 minutes ago
      Developer

      image

      note this was posts titled 1, 2, 3, 4, 5, I deleted 3, so you should see 3 lines.

      Easiest option, and perhaps the correct one would be to wrap the activity.html in an ng-container, with an ngIf checking whether the post is deleted (updating this variable in the delete function).

      The thing I'm chin scratching over is whether the remnants of the post (the horizontal line above) is desirable or not, as it offers a clear indicator of where the post was deleted, but in reality its just an artefact left over from the styling in the parent, and improper destruction of an element. -

      Edited by Ben Hayward 18 minutes ago
    • Ben Hayward @benhayward.ben added 1h of time spent at 2019-09-11 19 minutes ago

      added 1h of time spent at 2019-09-11

    • Ben Hayward @benhayward.ben removed Status::InProgress label 18 minutes ago

      removed Status::InProgress label

    • Ben Hayward @benhayward.ben added Status::InProgress scoped label 18 minutes ago

      added Status::InProgress scoped label

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply

    The one place for your designs

    Upload and view the latest designs for this issue. Consistent and easy to find, so everyone is up to date.

    Assignee
    Ben Hayward's avatar
    Ben Hayward @benhayward.ben
    Assign to
    none
    Epic
    None
    None
    Milestone
    None
    Assign milestone
    1h / 3h
    Time tracking
    Spent 1h
    Est 3h
    None
    Due date
    None
    5
    Labels
    Priority::2 - Normal Product::Newsfeed Sprint::09/11 - Nuanced Numbat Status::InProgress Type::Bug
    Assign labels
    • View project labels
    2
    Weight
    2
    Confidentiality
    Not confidential
    Lock issue
    Unlocked
    3
    3 participants
    user avatar
    Ben Hayward
    user avatar
    Mark Harding
    user avatar
    Nicholas Lewis
    Reference: minds/front#1732