Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 839
    • Issues 839
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 45
    • Merge Requests 45
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !549

Open
Opened 1 hour ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/NuancedNumbat](fix): Updated to return if button is not found. #1881

Closes #1881

By my testing in the blog editor this does not break any existing functionality. Please do test yourself.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "fix/button-style-error-sentry-1881" "origin/fix/button-style-error-sentry-1881"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "fix/button-style-error-sentry-1881"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/button-style-error-sentry-1881 into master
The source branch is 6 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #81653163 passed with warnings for dbe3fb66 on fix/button-style-error-sentry-1881
              Requires 2 more approvals from Devs and Deployers.
              Olivia Madrid
              Olivia Madrid
              Marcelo Rivera
              Marcelo Rivera
              Brian Hatchet
              Brian Hatchet
              Juan Manuel Solaro
              Juan Manuel Solaro
              Emiliano Balbuena
              Emiliano Balbuena
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #1881

              Deletes source branch

              • Discussion 0
              • Commits 1
              • Pipelines 1
              • Changes 1
              • Loading...
              • Ben Hayward @benhayward.ben changed milestone to %Misc. Q3 2019 1 hour ago

                changed milestone to %Misc. Q3 2019

              • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 1 hour ago

                added MR::Awaiting Review Squad::Yellow scoped labels

              • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
              Please register or sign in to reply
              0 Assignees
              None
              Assign to
              Misc. Q3 2019
              Milestone
              Misc. Q3 2019
              Assign milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Awaiting Review Squad::Yellow
              Assign labels
              • View project labels
              Lock merge request
              Unlocked
              9
              9 participants
              user avatar
              Olivia Madrid
              user avatar
              Marcelo Rivera
              user avatar
              Brian Hatchet
              user avatar
              Juan Manuel Solaro
              user avatar
              Emiliano Balbuena
              user avatar
              Mark Harding
              user avatar
              Martin Santangelo
              Reference: minds/front!549