Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 213
    • Issues 213
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 32
    • Merge Requests 32
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !319

Open
Opened 1 day ago by Guy Thouret@gthouret
  • Report abuse
Report abuse

(chore) Adapt recommended composer install script into our setup to remove the static hash comparison

(chore) Adapt recommended composer install script into our setup to remove the static hash comparison - Fixes #815

Closes #815

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b 815-composer-setup origin/815-composer-setup

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff 815-composer-setup

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge 815-composer-setup into master
The source branch is 4 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #81257129 failed for bc2f027b on 815-composer-setup
          Merge request approved. Approved by
          Emiliano Balbuena
          Emiliano Balbuena
          Mark Harding
          Mark Harding
          Rami Albatal
          Rami Albatal
          Marcelo Rivera
          Marcelo Rivera
          Brian Hatchet
          Brian Hatchet
          Martin Santangelo
          Martin Santangelo
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #815

          • Discussion 3
          • Commits 2
          • Pipelines 2
          • Changes 1
          0/1 thread resolved
          • Loading...
          • Guy Thouret @gthouret changed milestone to %sprint: Modest Monkey 1 day ago

            changed milestone to %sprint: Modest Monkey

          • Guy Thouret @gthouret added Priority::2 - Normal Squad::Blue Status::InProgress Type::Chore scoped labels 1 day ago

            added Priority::2 - Normal Squad::Blue Status::InProgress Type::Chore scoped labels

          • Martin Santangelo @msantang78 approved this merge request 1 day ago

            approved this merge request

          • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 day ago

            approved this merge request

          • Guy Thouret @gthouret added 3 commits 1 day ago

            added 3 commits

            • d01c821b...14f32dc5 - 2 commits from branch master
            • bc2f027b - Merge branch 'master' into 815-composer-setup

            Compare with previous version

          • Emiliano Balbuena @edgebal approved this merge request 1 day ago

            approved this merge request

          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 2 hours ago
            Last updated by Guy Thouret 1 minute ago
            tools/setup.sh
            4 4 rm -rf ../vendor
            5 5
            6 6 # Setup composer
            7 EXPECTED_SIGNATURE="$(wget -q -O - https://composer.github.io/installer.sig)"
            • Mark Harding
              Mark Harding @markeharding · 2 hours ago
              Owner

              Should installer.sig not be saved to our repo or CI? If composer repo is compromised then we could be vulnerable to installing a bad version.

            • Guy Thouret
              Guy Thouret @gthouret · 6 minutes ago
              Developer

              Depends on how likely a supply chain attack is?

              The hash/keys for verification look to be hosted separately to the installer itself... https://composer.github.io/pubkeys.html

            • Guy Thouret
              Guy Thouret @gthouret · 1 minute ago
              Developer

              In reality we'll probably just update the hash and continue on with our day as was the case with the most recent hash change. This just cuts out that step.

            • Please register or sign in to reply
          • Mark Harding @markeharding added MR::Requires Changes scoped label 2 hours ago

            added MR::Requires Changes scoped label

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          (08/28) Modest Monkey
          Milestone
          (08/28) Modest Monkey
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          5
          Labels
          MR::Requires Changes Priority::2 - Normal Squad::Blue Status::InProgress Type::Chore
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          8
          8 participants
          user avatar
          Mark Harding
          user avatar
          Rami Albatal
          user avatar
          Marcelo Rivera
          user avatar
          Brian Hatchet
          user avatar
          Martin Santangelo
          user avatar
          Ben Hayward
          user avatar
          Guy Thouret
          Reference: minds/engine!319