Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 877
    • Issues 877
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 47
    • Merge Requests 47
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !546

Open
Opened 47 minutes ago by Olivia Madrid@omadrid
  • Report abuse
Report abuse

Stop autoplaying videos from media pages

Attempts to resolve sentry issue referenced in #1780

Not totally clear on what's causing the problem. Seems to happen most reliably when I select 720p quality from video player controls on media pages - but only for some videos.

If I turn off autoplay, I stop getting the related error "Uncaught (in promise) DOMException" so am hoping that it also stops the "UnhandledRejection: Non-Error promise rejection captured with keys: [object has no keys]" as well.

Edited 39 minutes ago by Olivia Madrid

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b sentry-obj-no-keys-1780 origin/sentry-obj-no-keys-1780

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff sentry-obj-no-keys-1780

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge sentry-obj-no-keys-1780 into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #81457784 passed with warnings for 299714b6 on sentry-obj-no-keys-1780
              Requires 2 more approvals from Devs and Deployers.
              Juan Manuel Solaro
              Juan Manuel Solaro
              Ben Hayward
              Ben Hayward
              Marcelo Rivera
              Marcelo Rivera
              Martin Santangelo
              Martin Santangelo
              Emiliano Balbuena
              Emiliano Balbuena
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Mentions #1780

              • Discussion 0
              • Commits 2
              • Pipelines 2
              • Changes 1
              • Loading...
              • Olivia Madrid @omadrid changed title from (bug): stop autoplaying videos from media pages to Stop autoplaying videos from media pages 39 minutes ago

                changed title from (bug): stop autoplaying videos from media pages to Stop autoplaying videos from media pages

              • Olivia Madrid @omadrid changed the description 39 minutes ago

                changed the description

              • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
              Please register or sign in to reply
              0 Assignees
              None
              Assign to
              None
              Milestone
              None
              Assign milestone
              None
              Time tracking
              No estimate or time spent
              0
              Labels
              None
              Assign labels
              • View project labels
              Lock merge request
              Unlocked
              9
              9 participants
              user avatar
              Juan Manuel Solaro
              user avatar
              Ben Hayward
              user avatar
              Marcelo Rivera
              user avatar
              Martin Santangelo
              user avatar
              Emiliano Balbuena
              user avatar
              Brian Hatchet
              user avatar
              Mark Harding
              Reference: minds/front!546