0/4 threads resolved
added MR::Awaiting Review Squad::Green scoped labels
changed the description
approved this merge request
added 9 commits
- fe037a52...6d942fb6 - 8 commits from branch
master
- c4498c79 - Merge branch 'master' into feat/boost-e2e-1632
- fe037a52...6d942fb6 - 8 commits from branch
added 104 commits
- c4498c79...2be70043 - 102 commits from branch
master
- bef26578 - Merge branch 'master' of gitlab.com:minds/front into feat/boost-e2e-1632
- 3216ef88 - Updated
- c4498c79...2be70043 - 102 commits from branch
16 }); 17 cy.visit('/newsfeed/subscriptions'); 18 cy.location('pathname') 19 .should('eq', `/newsfeed/subscriptions`); 20 21 cy.route("GET", '**/api/v2/boost/prepare/**').as('prepare'); 22 cy.route("POST", '**/api/v2/boost/activity/**').as('activity'); 23 cy.route("GET", '**/api/v2/blockchain/wallet/balance*').as('balance'); 24 cy.route("GET", '**/api/v2/search/suggest/**').as('suggest'); 25 26 }); 27 28 it('should redirect a user to buy tokens when clicked', () => { 29 openTopModal(); 30 31 cy.get('.m-boost--creator-section-row .m-boost--creator-section-payment m-boost--creator-payment-methods > ul > li:nth-child(3) > i') - Developer
Let's stop using these nth child selectors
67 .wait('@prepare').then((xhr) => { 68 expect(xhr.status).to.equal(200); 69 expect(xhr.response.body.status).to.deep.equal("success"); 70 }).wait('@activity').then((xhr) => { 71 expect(xhr.status).to.equal(200); 72 expect(xhr.response.body.status).to.deep.equal("error"); 73 }); 74 75 cy.get('m-boost--creator > div > section > div > div > span') 76 .contains(duplicateError); 77 }); 78 79 it('should display an error if boost offer receiver has not signed up for rewards', () => { 80 openTopModal(); 81 82 cy.get('.m-boost--creator-section.m-boost--creator-section-type > ul > li:nth-child(2) > h4') - Developer
nth child selector
80 openTopModal(); 81 82 cy.get('.m-boost--creator-section.m-boost--creator-section-type > ul > li:nth-child(2) > h4') 83 .click(); 84 85 cy.get('m-boost--creator-p2p-search .m-boost--creator-wide-input input') 86 .type("minds").wait('@suggest').then((xhr) => { 87 expect(xhr.status).to.equal(200); 88 expect(xhr.response.body.status).to.deep.equal("success"); 89 }); 90 91 cy.get('.m-boost--creator-autocomplete--results .m-boost--creator-autocomplete--result-content') 92 .first() 93 .click({force: true}); 94 95 cy.get('m-boost--creator > div > section > div > div > span') - Developer
This feels pretty brittle
60 it('should error if the boost is a duplicate', () => { 61 openTopModal(); 62 cy.get('.m-boost--creator-section-amount input') 63 .type(5000); 64 65 cy.get('m-overlay-modal > div.m-overlay-modal > m-boost--creator button') 66 .click() 67 .wait('@prepare').then((xhr) => { 68 expect(xhr.status).to.equal(200); 69 expect(xhr.response.body.status).to.deep.equal("success"); 70 }).wait('@activity').then((xhr) => { 71 expect(xhr.status).to.equal(200); 72 expect(xhr.response.body.status).to.deep.equal("error"); 73 }); 74 75 cy.get('m-boost--creator > div > section > div > div > span') - Developer
This feels pretty brittle too. We should probably start using data attributes to isolate the elements per cypress' best practices