Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 897
    • Issues 897
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 46
    • Merge Requests 46
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !480

Open
Opened 1 month ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/KiltedKoala](feat): Added in boost e2e tests

Closes #1632

Edited 1 month ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feat/boost-e2e-1632 origin/feat/boost-e2e-1632

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff feat/boost-e2e-1632

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/boost-e2e-1632 into master
The source branch is 2 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #81107495 passed with warnings for 3216ef88 on feat/boost-e2e-1632
              Requires 2 more approvals from Devs and Deployers.
              Juan Manuel Solaro
              Juan Manuel Solaro
              Olivia Madrid
              Olivia Madrid
              Marcelo Rivera
              Marcelo Rivera
              Martin Santangelo
              Martin Santangelo
              Emiliano Balbuena
              Emiliano Balbuena
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #1632

              Deletes source branch

              • Discussion 4
              • Commits 5
              • Pipelines 5
              • Changes 1
              0/4 threads resolved
              • Loading...
              • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Green scoped labels 1 month ago

                added MR::Awaiting Review Squad::Green scoped labels

              • Ben Hayward @benhayward.ben changed the description 1 month ago

                changed the description

              • Ben Hayward @benhayward.ben added 1 commit 1 month ago

                added 1 commit

                • d0658450 - Moved here

                Compare with previous version

              • Ben Hayward @benhayward.ben added 1 commit 1 month ago

                added 1 commit

                • fe037a52 - Deleted old file

                Compare with previous version

              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 month ago

                approved this merge request

              • Brian Hatchet :speech_balloon: @brianhatchet added 9 commits 4 weeks ago

                added 9 commits

                • fe037a52...6d942fb6 - 8 commits from branch master
                • c4498c79 - Merge branch 'master' into feat/boost-e2e-1632

                Compare with previous version

              • Ben Hayward @benhayward.ben added 104 commits 1 day ago

                added 104 commits

                • c4498c79...2be70043 - 102 commits from branch master
                • bef26578 - Merge branch 'master' of gitlab.com:minds/front into feat/boost-e2e-1632
                • 3216ef88 - Updated

                Compare with previous version

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet started a thread on the diff 13 minutes ago
                cypress/integration/boost/boost-creator.spec.js
                16 });
                17 cy.visit('/newsfeed/subscriptions');
                18 cy.location('pathname')
                19 .should('eq', `/newsfeed/subscriptions`);
                20
                21 cy.route("GET", '**/api/v2/boost/prepare/**').as('prepare');
                22 cy.route("POST", '**/api/v2/boost/activity/**').as('activity');
                23 cy.route("GET", '**/api/v2/blockchain/wallet/balance*').as('balance');
                24 cy.route("GET", '**/api/v2/search/suggest/**').as('suggest');
                25
                26 });
                27
                28 it('should redirect a user to buy tokens when clicked', () => {
                29 openTopModal();
                30
                31 cy.get('.m-boost--creator-section-row .m-boost--creator-section-payment m-boost--creator-payment-methods > ul > li:nth-child(3) > i')
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 13 minutes ago
                  Developer

                  Let's stop using these nth child selectors

                • Please register or sign in to reply
              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet started a thread on the diff 13 minutes ago
                cypress/integration/boost/boost-creator.spec.js
                67 .wait('@prepare').then((xhr) => {
                68 expect(xhr.status).to.equal(200);
                69 expect(xhr.response.body.status).to.deep.equal("success");
                70 }).wait('@activity').then((xhr) => {
                71 expect(xhr.status).to.equal(200);
                72 expect(xhr.response.body.status).to.deep.equal("error");
                73 });
                74
                75 cy.get('m-boost--creator > div > section > div > div > span')
                76 .contains(duplicateError);
                77 });
                78
                79 it('should display an error if boost offer receiver has not signed up for rewards', () => {
                80 openTopModal();
                81
                82 cy.get('.m-boost--creator-section.m-boost--creator-section-type > ul > li:nth-child(2) > h4')
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 13 minutes ago
                  Developer

                  nth child selector

                • Please register or sign in to reply
              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet started a thread on the diff 13 minutes ago
                cypress/integration/boost/boost-creator.spec.js
                80 openTopModal();
                81
                82 cy.get('.m-boost--creator-section.m-boost--creator-section-type > ul > li:nth-child(2) > h4')
                83 .click();
                84
                85 cy.get('m-boost--creator-p2p-search .m-boost--creator-wide-input input')
                86 .type("minds").wait('@suggest').then((xhr) => {
                87 expect(xhr.status).to.equal(200);
                88 expect(xhr.response.body.status).to.deep.equal("success");
                89 });
                90
                91 cy.get('.m-boost--creator-autocomplete--results .m-boost--creator-autocomplete--result-content')
                92 .first()
                93 .click({force: true});
                94
                95 cy.get('m-boost--creator > div > section > div > div > span')
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 13 minutes ago
                  Developer

                  This feels pretty brittle

                • Please register or sign in to reply
              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet started a thread on the diff 13 minutes ago
                cypress/integration/boost/boost-creator.spec.js
                60 it('should error if the boost is a duplicate', () => {
                61 openTopModal();
                62 cy.get('.m-boost--creator-section-amount input')
                63 .type(5000);
                64
                65 cy.get('m-overlay-modal > div.m-overlay-modal > m-boost--creator button')
                66 .click()
                67 .wait('@prepare').then((xhr) => {
                68 expect(xhr.status).to.equal(200);
                69 expect(xhr.response.body.status).to.deep.equal("success");
                70 }).wait('@activity').then((xhr) => {
                71 expect(xhr.status).to.equal(200);
                72 expect(xhr.response.body.status).to.deep.equal("error");
                73 });
                74
                75 cy.get('m-boost--creator > div > section > div > div > span')
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 13 minutes ago
                  Developer

                  This feels pretty brittle too. We should probably start using data attributes to isolate the elements per cypress' best practices

                • Please register or sign in to reply
              • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
              Please register or sign in to reply
              0 Assignees
              None
              Assign to
              None
              Milestone
              None
              Assign milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Awaiting Review Squad::Green
              Assign labels
              • View project labels
              Lock merge request
              Unlocked
              9
              9 participants
              user avatar
              Juan Manuel Solaro
              user avatar
              Olivia Madrid
              user avatar
              Marcelo Rivera
              user avatar
              Martin Santangelo
              user avatar
              Emiliano Balbuena
              user avatar
              Brian Hatchet
              user avatar
              Guy Thouret
              Reference: minds/front!480