Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Mobile
Minds Mobile
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 211
    • Issues 211
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 14
    • Merge Requests 14
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • Minds
  • Minds MobileMinds Mobile
  • Merge Requests
  • !325

Open
Opened 1 week ago by Martin Santangelo@msantang789 of 10 tasks completed9/10 tasks
  • Report abuse
Report abuse

WIP: [Sprint/ModestMonkey] wire epic 37

  • create a tiers carousel component
  • add tiers to wire creator
  • replace deprecated QRcode package
  • update vector icons and menu packages
  • add payment methods support
  • add bitcoin support
  • change wire text
  • wire refactor and clean up
  • add eth support
  • add usd support

closes #1220

Edited 1 hour ago by Martin Santangelo

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b epic/wire-37 origin/epic/wire-37

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/release/3.10.0
git merge --no-ff epic/wire-37

Step 4. Push the result of the merge to GitLab

git push origin release/3.10.0

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge epic/wire-37 into release/3.10.0
The source branch is 19 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Could not retrieve the pipeline status. For troubleshooting steps, read the documentation.
Requires 2 more approvals.
There are merge conflicts. Resolve these conflicts or ask someone with write access to this repository to merge it locally
You can merge this merge request manually using the
  • Discussion 2
  • Commits 14
  • Pipelines 7
  • Changes 30
0/1 thread resolved
  • Loading...
  • Martin Santangelo @msantang78 changed milestone to %sprint: Modest Monkey 1 week ago

    changed milestone to %sprint: Modest Monkey

  • Martin Santangelo @msantang78 added Squad::Green scoped label 1 week ago

    added Squad::Green scoped label

  • Martin Santangelo @msantang78 marked the task create a tiers carousel component as completed 1 week ago

    marked the task create a tiers carousel component as completed

  • Martin Santangelo @msantang78 marked the task add tiers to wire creator as completed 1 week ago

    marked the task add tiers to wire creator as completed

  • Martin Santangelo @msantang78 added 1 commit 1 week ago

    added 1 commit

    • ed176ea1 - (feat) update wire text

    Compare with previous version

  • Martin Santangelo @msantang78 added 1 commit 1 week ago

    added 1 commit

    • 176092cc - (chore) update ios project

    Compare with previous version

  • Martin Santangelo @msantang78 added 2 commits 6 days ago

    added 2 commits

    • 2d533450 - (fix) tiers carousel error when user doesn't have rewards
    • 49662961 - (chore) fix unused var/import detection

    Compare with previous version

  • Martin Santangelo @msantang78 added 1 commit 4 days ago

    added 1 commit

    • bc618baf - (chore) replace qrcode package - vector icons and menu packages updated

    Compare with previous version

  • Martin Santangelo @msantang78 added 1 commit 4 days ago

    added 1 commit

    • f8095bdf - WIP: payment selector, btc payment, wire refactor

    Compare with previous version

  • Martin Santangelo @msantang78 marked the task add payment methods support as completed 4 days ago

    marked the task add payment methods support as completed

  • Martin Santangelo @msantang78 changed the description 4 days ago

    changed the description

  • Martin Santangelo @msantang78 added 6 commits 1 hour ago

    added 6 commits

    • c01775f6 - WIP: payment selector, btc payment, wire refactor
    • eebcead7 - (fix) wire input number format
    • 336d56ae - (fix) regexp error in production build
    • 00d0d96b - (fix) error accessing encrypted storage
    • f25c9fd3 - (fix) copy/paste wallet import key
    • fc773a1b - (feat) ethereum wire

    Compare with previous version

    Toggle commit list
  • Martin Santangelo @msantang78 marked the task add eth support as completed 1 hour ago

    marked the task add eth support as completed

  • Martin Santangelo @msantang78 marked the task wire refactor and clean up as completed 1 hour ago

    marked the task wire refactor and clean up as completed

  • Ben Hayward
    Ben Hayward @benhayward.ben started a thread on the diff 50 minutes ago
    Last updated by Ben Hayward 47 minutes ago
    src/blockchain/services/Web3Service.js
    133 * @param {number} amount eth amount
    134 */
    135 async sendEth(to, amount) {
    136 const toHex = this.web3.utils.toHex;
    137 const baseOptions = await this.getTransactionOptions();
    138 const privateKey = await BlockchainWalletService.unlock(baseOptions.from);
    139
    140 const nonce = await this.web3.eth.getTransactionCount(baseOptions.from);
    141
    142 const tx = {
    143 nonce,
    144 to,
    145 from: baseOptions.from,
    146 value: toHex( this.web3.utils.toWei(amount, 'ether') ),
    147 gas: toHex(21000),
    148 gasPrice: toHex( this.web3.utils.toWei('2', 'Gwei') ), // converts the gwei price to wei
    • Ben Hayward
      Ben Hayward @benhayward.ben · 50 minutes ago
      Developer

      I don't think there's necessarily anything you can do different here as its the same on the front-end, but I strongly feel we should be getting gas prices dynamically.

    • Ben Hayward
      Ben Hayward @benhayward.ben · 47 minutes ago
      Developer

      Check out this https://ethereum.stackexchange.com/a/52974

      Unsure if its possible in this context but worth a look

    • Please register or sign in to reply
  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
0 Assignees
None
Assign to
sprint: Modest Monkey
Milestone
sprint: Modest Monkey
Assign milestone
None
Time tracking
No estimate or time spent
1
Labels
Squad::Green
Assign labels
  • View project labels
Lock merge request
Unlocked
2
2 participants
user avatar
Ben Hayward
user avatar
Martin Santangelo
Reference: minds/mobile-native!325