Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 895
    • Issues 895
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 46
    • Merge Requests 46
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !501

Merged
Opened 2 weeks ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/LuckyLizard](fix) Boost console feed #1596

Closes #1596 (closed)

Depends on: engine!311 (merged)

Try the create boost button for the different pages here https://fix-boost-console-feed-1596.minds.io/boost/console/newsfeed/create

Edited 3 days ago by Ben Hayward
Request to merge fix/boost-console-feed-1596 into master
  • Email patches
  • Plain diff
Pipeline #79843686 passed with warnings for 6b18a97a on fix/boost-console-feed-1596
              Merge request approved. Approved by
              Nicholas Lewis
              Nicholas Lewis
              Brian Hatchet
              Brian Hatchet
              Olivia Madrid
              Olivia Madrid
              Guy Thouret
              Guy Thouret
              Emiliano Balbuena
              Emiliano Balbuena
              Martin Santangelo
              Martin Santangelo
              Marcelo Rivera
              Marcelo Rivera

              Merged by Brian Hatchet 1 hour ago

              The changes were merged into master with 4cfc63bc

              The source branch has been deleted

              Closed #1596 (closed)

              Pipeline #80766509 running for 4cfc63bc on master
                            • Discussion 17
                            • Commits 13
                            • Pipelines 10
                            • Changes 5
                            2/2 threads resolved
                            • Loading...
                            • Ben Hayward @benhayward.ben added Squad::Green scoped label 2 weeks ago

                              added Squad::Green scoped label

                            • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

                              added 1 commit

                              • 3f7c0e7e - Fixed up tests and formatted

                              Compare with previous version

                            • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label 2 weeks ago

                              added MR::Awaiting Review scoped label

                            • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

                              added 1 commit

                              • db32dcc9 - Minor fix

                              Compare with previous version

                            • Mark Harding
                              Mark Harding @markeharding started a thread on the diff 2 weeks ago
                              Resolved by Ben Hayward 1 week ago
                            • Ben Hayward @benhayward.ben mentioned in issue #1596 (closed) 2 weeks ago

                              mentioned in issue #1596 (closed)

                            • Brian Hatchet :speech_balloon: @brianhatchet marked as a Work In Progress 2 weeks ago

                              marked as a Work In Progress

                            • Brian Hatchet :speech_balloon: @brianhatchet changed the description 2 weeks ago

                              changed the description

                            • Brian Hatchet :speech_balloon: @brianhatchet unmarked as a Work In Progress 2 weeks ago

                              unmarked as a Work In Progress

                            • Brian Hatchet
                              Brian Hatchet :speech_balloon: @brianhatchet · 2 weeks ago
                              Developer

                              I tested this and it looks good. Once you address Mark's comment above, I will give it my approval.

                              Edited by Brian Hatchet 2 weeks ago
                            • Ben Hayward @benhayward.ben added 1 commit 1 week ago

                              added 1 commit

                              • 2deab016 - Updated endpoint for newsfeed

                              Compare with previous version

                            • Ben Hayward @benhayward.ben resolved all threads 1 week ago

                              resolved all threads

                            • Ben Hayward @benhayward.ben added 1 commit 1 week ago

                              added 1 commit

                              • 2a4f4f00 - Fixed failing tests

                              Compare with previous version

                            • Ben Hayward
                              Ben Hayward @benhayward.ben · 1 week ago
                              Developer

                              Cool, we should be ready to go if you'd be so kind as to quickly test again

                            • Brian Hatchet :speech_balloon: @brianhatchet added 53 commits 1 week ago

                              added 53 commits

                              • 2a4f4f00...5ed6e576 - 52 commits from branch master
                              • 9a219148 - Merge remote-tracking branch 'origin/master' into fix/boost-console-feed-1596

                              Compare with previous version

                            • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 week ago

                              approved this merge request

                            • Brian Hatchet :speech_balloon: @brianhatchet unapproved this merge request 1 week ago

                              unapproved this merge request

                            • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 week ago

                              approved this merge request

                            • Mark Harding
                              Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
                              Resolved by Ben Hayward 1 week ago
                            • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 week ago

                              added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

                            • Ben Hayward @benhayward.ben added 1 commit 1 week ago

                              added 1 commit

                              • 704793e8 - Updated to pull sidebar from v2 feeds endpoint

                              Compare with previous version

                            • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 1 week ago

                              added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label

                            • Ben Hayward @benhayward.ben resolved all threads 1 week ago

                              resolved all threads

                            • Ben Hayward @benhayward.ben resolved all threads 1 week ago

                              resolved all threads

                            • Ben Hayward @benhayward.ben added 12 commits 1 week ago

                              added 12 commits

                              • 704793e8...265cc9d3 - 11 commits from branch master
                              • 3b97a797 - Merge branch 'master' of gitlab.com:minds/front into fix/boost-console-feed-1596

                              Compare with previous version

                            • Zoraya
                              Zoraya @Zoraya · 1 week ago

                              Hi Minds Devs, good morning.

                              @benhayward.ben Just would like to follow-up if there is a possibility for issue this getting fixed?

                              Thank you for all your efforts.

                              All the best.

                            • Ben Hayward @benhayward.ben added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 4 days ago

                              added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

                            • Ben Hayward
                              Ben Hayward @benhayward.ben · 4 days ago
                              Developer

                              Found 2 issues in this @Zoraya, so both will need to be fixed, and are on my cards to do shortly. No worries! Apologies for the delay.

                            • Zoraya
                              Zoraya @Zoraya · 4 days ago

                              Thank you, @benhayward.ben. Have a great week :)

                            • Ben Hayward @benhayward.ben added 1 commit 3 days ago

                              added 1 commit

                              • 6b18a97a - Changed endpoint for content feed

                              Compare with previous version

                            • Ben Hayward @benhayward.ben changed the description 3 days ago

                              changed the description

                            • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 3 days ago

                              added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label

                            • Ben Hayward @benhayward.ben assigned to @javanick and @brianhatchet 1 day ago

                              assigned to @javanick and @brianhatchet

                            • Zoraya
                              Zoraya @Zoraya · 23 hours ago

                              Thank you for updating this despite the workload @benhayward.ben

                              I hope this gets fixed soon :)

                              Good day!

                            • Ben Hayward
                              Ben Hayward @benhayward.ben · 21 hours ago
                              Developer

                              Any time, turned out to be quite the large change in the end.

                            • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 18 hours ago

                              approved this merge request

                            • Nicholas Lewis @javanick approved this merge request 18 hours ago

                              approved this merge request

                            • Brian Hatchet :speech_balloon: @brianhatchet mentioned in commit 4cfc63bc 1 hour ago

                              mentioned in commit 4cfc63bc

                            • Brian Hatchet :speech_balloon: @brianhatchet merged 1 hour ago

                              merged

                            • Zoraya
                              Zoraya @Zoraya · 1 hour ago

                              Hi @brianhatchet

                              Is the issue fixed now? I still cannot see any post in my sidebar boost console. The last post was July 21, 2019.

                              Thank you.

                            • Ben Hayward
                              Ben Hayward @benhayward.ben · 1 hour ago
                              Developer

                              image

                              When the first 4/5 circles above are finished, it will be available in canary mode for 24 hours. Following that so long as no issues appear, it'll be in the main branch. I'll keep an eye on it, please do feel free to test and get back to me if you find any issues

                            • Ben Hayward
                              Ben Hayward @benhayward.ben · 1 hour ago
                              Developer

                              Sorry, a bit short there because I am rushing around - I do appreciate you asking, GitLab is a complicated bit of kit for none developers, and It's nice to see users exploring it.

                            • Zoraya
                              Zoraya @Zoraya · 49 minutes ago

                              I just want to know if you and your team will still fix it.

                              I do not understand so I need to know if it's still on progress so I can wait.

                              Thank you Ben @benhayward.ben

                              Sorry if I'm confused.

                            • Ben Hayward
                              Ben Hayward @benhayward.ben · 37 minutes ago
                              Developer

                              No worries, If you're receiving Canary changes here https://www.minds.com/canary, you should have it quite soon.

                            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                            Please register or sign in to reply
                            2 Assignees
                            Brian Hatchet's avatar
                            Nicholas Lewis's avatar
                            Assign to
                            None
                            Milestone
                            None
                            Assign milestone
                            None
                            Time tracking
                            No estimate or time spent
                            2
                            Labels
                            MR::Awaiting Review Squad::Green
                            Assign labels
                            • View project labels
                            Lock merge request
                            Unlocked
                            11
                            11 participants
                            user avatar
                            Olivia Madrid
                            user avatar
                            Guy Thouret
                            user avatar
                            Emiliano Balbuena
                            user avatar
                            Martin Santangelo
                            user avatar
                            Marcelo Rivera
                            user avatar
                            Mark Harding
                            user avatar
                            Juan Manuel Solaro
                            Reference: minds/front!501

                            Revert this merge request

                            This will create a new commit in order to revert the existing changes.

                            Switch branch
                            Cancel
                            A new branch will be created in your fork and a new merge request will be started.

                            Cherry-pick this merge request

                            Switch branch
                            Cancel
                            A new branch will be created in your fork and a new merge request will be started.