Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 242
    • Issues 242
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 32
    • Merge Requests 32
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !307

Merged
Opened 1 week ago by Brian Hatchet@brianhatchet:speech_balloon:
  • Report abuse
Report abuse

Epic/permissions open channels

Let's get this closed off so we can get all the e2e tests up and running before I commit the next big block of permissions

Edited 1 day ago by Brian Hatchet
Request to merge epic/permissions-open-channels into master
  • Email patches
  • Plain diff
Pipeline #80600629 passed for 03c117f4 on epic/permissions-open-channels
          Merge request approved. Approved by
          Emiliano Balbuena
          Emiliano Balbuena
          Ben Hayward
          Ben Hayward
          Martin Santangelo
          Martin Santangelo
          Marcelo Rivera
          Marcelo Rivera
          Mark Harding
          Mark Harding
          Rami Albatal
          Rami Albatal

          Merged by Brian Hatchet 9 minutes ago

          The changes were merged into master with fd67bc47

          The source branch has been deleted

          Pipeline #80778517 running for fd67bc47 on master
                      • Discussion 29
                      • Commits 12
                      • Pipelines 10
                      • Changes 38
                      14/14 threads resolved
                      • Loading...
                      • Brian Hatchet :speech_balloon: @brianhatchet changed milestone to %sprint: Modest Monkey 1 week ago

                        changed milestone to %sprint: Modest Monkey

                      • Brian Hatchet :speech_balloon: @brianhatchet added Squad::Green scoped label 1 week ago

                        added Squad::Green scoped label

                      • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 1 week ago

                        added 1 commit

                        • 34aca270 - Linting

                        Compare with previous version

                      • Brian Hatchet :speech_balloon: @brianhatchet added 6 commits 2 days ago

                        added 6 commits

                        • 34aca270...d684846f - 5 commits from branch master
                        • f7700208 - Merge remote-tracking branch 'origin/master' into epic/permissions-open-channels

                        Compare with previous version

                      • Brian Hatchet :speech_balloon: @brianhatchet unmarked as a Work In Progress 1 day ago

                        unmarked as a Work In Progress

                      • Brian Hatchet :speech_balloon: @brianhatchet changed the description 1 day ago

                        changed the description

                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 21 hours ago
                        Resolved by Brian Hatchet 19 hours ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 21 hours ago
                        Resolved by Brian Hatchet 20 hours ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 21 hours ago
                        Resolved by Brian Hatchet 20 hours ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 21 hours ago
                        Resolved by Brian Hatchet 20 hours ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 21 hours ago
                        Resolved by Brian Hatchet 20 hours ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on the diff 21 hours ago
                        Resolved by Brian Hatchet 20 hours ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 21 hours ago
                        Resolved by Brian Hatchet 20 hours ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 21 hours ago
                        Resolved by Brian Hatchet 20 hours ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 21 hours ago
                        Resolved by Brian Hatchet 20 hours ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 21 hours ago
                        Resolved by Brian Hatchet 20 hours ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 21 hours ago
                        Resolved by Brian Hatchet 20 hours ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 21 hours ago
                        Resolved by Brian Hatchet 20 hours ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 21 hours ago
                        Resolved by Brian Hatchet 20 hours ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on the diff 21 hours ago
                        Resolved by Brian Hatchet 20 hours ago
                      • Mark Harding @markeharding added MR::Requires Changes scoped label 21 hours ago

                        added MR::Requires Changes scoped label

                      • Mark Harding
                        Mark Harding @markeharding · 21 hours ago
                        Owner

                        Looks great. How are we feeling about caching?

                      • Brian Hatchet
                        Brian Hatchet :speech_balloon: @brianhatchet · 20 hours ago
                        Developer

                        That it is one of the hardest problems in CS next to naming of things and feature flags, but we'll probably need it eventually. This hole this is pretty static beyond potential retrieval of new entities, which are already potentially cached.

                        Once we get it all humming along, it shouldn't be too hard to cache persistent versions of these, but the dynamic entity calculation will be fun to refresh

                      • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 20 hours ago

                        added 1 commit

                        • 31f45fc5 - MR changes

                        Compare with previous version

                      • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 19 hours ago

                        added 1 commit

                        • 03c117f4 - Lesson learning return type annotations don't work with derived classes. Must return an interface

                        Compare with previous version

                      • Brian Hatchet :speech_balloon: @brianhatchet resolved all threads 19 hours ago

                        resolved all threads

                      • Emiliano Balbuena @edgebal approved this merge request 10 minutes ago

                        approved this merge request

                      • Brian Hatchet :speech_balloon: @brianhatchet merged 9 minutes ago

                        merged

                      • Brian Hatchet :speech_balloon: @brianhatchet mentioned in commit fd67bc47 9 minutes ago

                        mentioned in commit fd67bc47

                      • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                      Please register or sign in to reply
                      Assignee
                      Brian Hatchet's avatar
                      Brian Hatchet @brianhatchet
                      Assign to
                      sprint: Modest Monkey
                      Milestone
                      sprint: Modest Monkey
                      Assign milestone
                      None
                      Time tracking
                      No estimate or time spent
                      2
                      Labels
                      MR::Requires Changes Squad::Green
                      Assign labels
                      • View project labels
                      Lock merge request
                      Unlocked
                      7
                      7 participants
                      user avatar
                      Ben Hayward
                      user avatar
                      Martin Santangelo
                      user avatar
                      Marcelo Rivera
                      user avatar
                      Mark Harding
                      user avatar
                      Rami Albatal
                      user avatar
                      Brian Hatchet
                      user avatar
                      Emiliano Balbuena
                      Reference: minds/engine!307

                      Revert this merge request

                      This will create a new commit in order to revert the existing changes.

                      Switch branch
                      Cancel
                      A new branch will be created in your fork and a new merge request will be started.

                      Cherry-pick this merge request

                      Switch branch
                      Cancel
                      A new branch will be created in your fork and a new merge request will be started.