Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Mobile
Minds Mobile
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 205
    • Issues 205
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 12
    • Merge Requests 12
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • Minds
  • Minds MobileMinds Mobile
  • Merge Requests
  • !334

Merged
Opened 47 minutes ago by Martin Santangelo@msantang78
  • Report abuse
Report abuse

[Sprint/ModestMonkey] (fix) feed service error when the request fails and there is no local data to show

fix https://sentry.io/organizations/minds-inc/issues/1178044550/?project=1538735&query=is%3Aunresolved&statsPeriod=14d

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feat/fix-feed-service-network-request-no-local-data-error origin/feat/fix-feed-service-network-request-no-local-data-error

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/release/3.9.1
git merge --no-ff feat/fix-feed-service-network-request-no-local-data-error

Step 4. Push the result of the merge to GitLab

git push origin release/3.9.1

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/fix-feed-service-network-request-no-local-data-error into release/3.9.1
  • Email patches
  • Plain diff
Could not retrieve the pipeline status. For troubleshooting steps, read the documentation.
Merge request approved. Approved by
Marcelo Rivera
Marcelo Rivera
Brian Hatchet
Brian Hatchet

Merged by Martin Santangelo 4 minutes ago

The changes were merged into release/3.9.1 with 3264d4b9

Pipeline #80597278 running for 3264d4b9 on release/3.9.1
          • Discussion 0
          • Commits 1
          • Pipelines 1
          • Changes 1
          • Loading...
          • Martin Santangelo @msantang78 changed milestone to %sprint: Modest Monkey 47 minutes ago

            changed milestone to %sprint: Modest Monkey

          • Martin Santangelo @msantang78 added MR::Awaiting Review Squad::Green scoped labels 47 minutes ago

            added MR::Awaiting Review Squad::Green scoped labels

          • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 41 minutes ago

            approved this merge request

          • Marcelo Rivera @eiennohi approved this merge request 40 minutes ago

            approved this merge request

          • Martin Santangelo @msantang78 enabled an automatic merge when the pipeline for 088cc08e succeeds 9 minutes ago

            enabled an automatic merge when the pipeline for 088cc08e succeeds

          • Martin Santangelo @msantang78 mentioned in commit 3264d4b9 4 minutes ago

            mentioned in commit 3264d4b9

          • Martin Santangelo @msantang78 merged 4 minutes ago

            merged

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          sprint: Modest Monkey
          Milestone
          sprint: Modest Monkey
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Awaiting Review Squad::Green
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          3
          3 participants
          user avatar
          Martin Santangelo
          user avatar
          Marcelo Rivera
          user avatar
          Brian Hatchet
          Reference: minds/mobile-native!334

          Revert this merge request

          This will create a new commit in order to revert the existing changes.

          Switch branch
          Cancel
          A new branch will be created in your fork and a new merge request will be started.

          Cherry-pick this merge request

          Switch branch
          Cancel
          A new branch will be created in your fork and a new merge request will be started.