Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 896
    • Issues 896
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 49
    • Merge Requests 49
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !531

Merged
Opened 6 days ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/ModestMonkey](fix): Return void if there is no selected or deselected image

Closes #1791 (closed)

The issue is in the image embed, on image click. This is bound as an onclick event and if its firing on an image, and if e.target doesn't exist, we should just be returning void.

To test please go make a blog, add an image, click it, deselect etc.

Edited 6 days ago by Ben Hayward
Request to merge fix/blogs-image-select-1791 into master
  • Email patches
  • Plain diff
Pipeline #80532798 passed with warnings for 1aa5d2c7 on fix/blogs-image-select-1791
              Merge request approved. Approved by
              Brian Hatchet
              Brian Hatchet
              Emiliano Balbuena
              Emiliano Balbuena
              Guy Thouret
              Guy Thouret
              Olivia Madrid
              Olivia Madrid
              Juan Manuel Solaro
              Juan Manuel Solaro
              Mark Harding
              Mark Harding
              Martin Santangelo
              Martin Santangelo

              Merged by Mark Harding 15 minutes ago

              The changes were merged into master with 60a74dfa

              The source branch has been deleted

              Closed #1791 (closed)

              Pipeline #80592826 running for 60a74dfa on master
                            • Discussion 4
                            • Commits 5
                            • Pipelines 6
                            • Changes 1
                            2/2 threads resolved
                            • Loading...
                            • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Green scoped labels 6 days ago

                              added MR::Awaiting Review Squad::Green scoped labels

                            • Ben Hayward @benhayward.ben changed the description 6 days ago

                              changed the description

                            • Ben Hayward
                              Ben Hayward @benhayward.ben · 6 days ago
                              Developer

                              Note: failed pipeline is the cleanup pipeline.

                            • Mark Harding
                              Mark Harding @markeharding started a thread on an old version of the diff 6 days ago
                              Resolved by Ben Hayward 6 days ago
                            • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 6 days ago

                              added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

                            • Ben Hayward @benhayward.ben added 1 commit 6 days ago

                              added 1 commit

                              • e5238358 - Update embed-image.plugin.ts

                              Compare with previous version

                            • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 6 days ago

                              added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label

                            • Ben Hayward @benhayward.ben resolved all threads 6 days ago

                              resolved all threads

                            • Ben Hayward @benhayward.ben mentioned in issue #1813 3 days ago

                              mentioned in issue #1813

                            • Mark Harding
                              Mark Harding @markeharding started a thread on an old version of the diff 3 days ago
                              Resolved by Ben Hayward 3 days ago
                            • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 3 days ago

                              added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

                            • Ben Hayward @benhayward.ben added 1 commit 3 days ago

                              added 1 commit

                              • cbabacd1 - Updated for feedback

                              Compare with previous version

                            • Ben Hayward @benhayward.ben added 1 commit 3 days ago

                              added 1 commit

                              • aa71ff28 - Fixed null images causing error

                              Compare with previous version

                            • Ben Hayward @benhayward.ben resolved all threads 3 days ago

                              resolved all threads

                            • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 3 days ago

                              added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label

                            • Ben Hayward @benhayward.ben added 1 commit 5 hours ago

                              added 1 commit

                              • 1aa5d2c7 - Update embed-image.plugin.ts

                              Compare with previous version

                            • Emiliano Balbuena @edgebal approved this merge request 5 hours ago

                              approved this merge request

                            • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 5 hours ago

                              approved this merge request

                            • Mark Harding @markeharding merged 15 minutes ago

                              merged

                            • Mark Harding @markeharding mentioned in commit 60a74dfa 15 minutes ago

                              mentioned in commit 60a74dfa

                            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                            Please register or sign in to reply
                            0 Assignees
                            None
                            Assign to
                            None
                            Milestone
                            None
                            Assign milestone
                            None
                            Time tracking
                            No estimate or time spent
                            2
                            Labels
                            MR::Awaiting Review Squad::Green
                            Assign labels
                            • View project labels
                            Lock merge request
                            Unlocked
                            9
                            9 participants
                            user avatar
                            Guy Thouret
                            user avatar
                            Olivia Madrid
                            user avatar
                            Juan Manuel Solaro
                            user avatar
                            Mark Harding
                            user avatar
                            Martin Santangelo
                            user avatar
                            Marcelo Rivera
                            user avatar
                            Brian Hatchet
                            Reference: minds/front!531

                            Revert this merge request

                            This will create a new commit in order to revert the existing changes.

                            Switch branch
                            Cancel
                            A new branch will be created in your fork and a new merge request will be started.

                            Cherry-pick this merge request

                            Switch branch
                            Cancel
                            A new branch will be created in your fork and a new merge request will be started.