Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 896
    • Issues 896
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 49
    • Merge Requests 49
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !536

Merged
Opened 5 hours ago by Guy Thouret@gthouret
  • Report abuse
Report abuse

(fix) Fix TypeError being thrown on window resize of new blog page

Easy fix for error being thrown - don't allow classList to be called null.

See #1777 for steps to recreate/test issue

Request to merge fix/1777-typeerror into master
  • Email patches
  • Plain diff
Pipeline #80526934 passed with warnings for 66e47067 on fix/1777-typeerror
              Merge request approved. Approved by
              Mark Harding
              Mark Harding
              Brian Hatchet
              Brian Hatchet
              Ben Hayward
              Ben Hayward
              Olivia Madrid
              Olivia Madrid
              Juan Manuel Solaro
              Juan Manuel Solaro
              Emiliano Balbuena
              Emiliano Balbuena

              Merged by Mark Harding 21 minutes ago

              The changes were merged into master with 0b8b5170

              The source branch has been deleted

              Mentions #1777

              Pipeline #80590322 running for 0b8b5170 on master
                            • Discussion 0
                            • Commits 1
                            • Pipelines 1
                            • Changes 1
                            • Loading...
                            • Guy Thouret @gthouret changed milestone to %sprint: Modest Monkey 5 hours ago

                              changed milestone to %sprint: Modest Monkey

                            • Guy Thouret @gthouret added MR::Awaiting Review Squad::Blue scoped labels 5 hours ago

                              added MR::Awaiting Review Squad::Blue scoped labels

                            • Mark Harding @markeharding approved this merge request 21 minutes ago

                              approved this merge request

                            • Mark Harding @markeharding merged 21 minutes ago

                              merged

                            • Mark Harding @markeharding mentioned in commit 0b8b5170 21 minutes ago

                              mentioned in commit 0b8b5170

                            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                            Please register or sign in to reply
                            0 Assignees
                            None
                            Assign to
                            sprint: Modest Monkey
                            Milestone
                            sprint: Modest Monkey
                            Assign milestone
                            None
                            Time tracking
                            No estimate or time spent
                            2
                            Labels
                            MR::Awaiting Review Squad::Blue
                            Assign labels
                            • View project labels
                            Lock merge request
                            Unlocked
                            9
                            9 participants
                            user avatar
                            Brian Hatchet
                            user avatar
                            Ben Hayward
                            user avatar
                            Olivia Madrid
                            user avatar
                            Juan Manuel Solaro
                            user avatar
                            Emiliano Balbuena
                            user avatar
                            Martin Santangelo
                            user avatar
                            Marcelo Rivera
                            Reference: minds/front!536

                            Revert this merge request

                            This will create a new commit in order to revert the existing changes.

                            Switch branch
                            Cancel
                            A new branch will be created in your fork and a new merge request will be started.

                            Cherry-pick this merge request

                            Switch branch
                            Cancel
                            A new branch will be created in your fork and a new merge request will be started.