Epic/permissions open channels
Let's get this closed off so we can get all the e2e tests up and running before I commit the next big block of permissions
changed milestone to %sprint: Modest Monkey
added Squad::Green scoped label
added 6 commits
- 34aca270...d684846f - 5 commits from branch
master - f7700208 - Merge remote-tracking branch 'origin/master' into epic/permissions-open-channels
- 34aca270...d684846f - 5 commits from branch
unmarked as a Work In Progress
changed the description
Last updated by Brian Hatchet21 /** @var bool */ 22 private $isBanned = false; 23 /** @var User */ 24 private $user; 25 /** @var Roles */ 26 private $roles; 27 /** @var array */ 28 private $entities; 29 /** @var ChannelRoleCalculator */ 30 private $channelRoleCalculator; 31 /** @var GroupRoleCalculator */ 32 private $groupRoleCalculator; 33 /** @var EntitiesBuilder */ 34 private $entitiesBuilder; 35 36 public function setUser(User $user) - Owner
Return type would be nice
changed this line in version 4 of the diff
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
added MR::Requires Changes scoped label
- Owner
Looks great. How are we feeling about caching?
DeveloperThat it is one of the hardest problems in CS next to naming of things and feature flags, but we'll probably need it eventually. This hole this is pretty static beyond potential retrieval of new entities, which are already potentially cached.
Once we get it all humming along, it shouldn't be too hard to cache persistent versions of these, but the dynamic entity calculation will be fun to refresh