Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 897
    • Issues 897
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 51
    • Merge Requests 51
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !532

Merged
Opened 5 days ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/ModestMonkey](chore): Added linting to pre-commit hook #1807

Closes #1807 (closed)

To Test

Pull the branch locally, install the new packages, try commit a) unlinted code. b) fit/describes. c) build errors should be caught on push.

Package Justification

I did do some research before this and found Husky (https://github.com/typicode/husky/) suggested as a way to get hooks to run simply cross-platform, nicely. Looking at their project it seems to be robust, actively maintained and used quite widely.

The other package I wanted to use is https://github.com/azz/pretty-quick which seemed the best to quickly lint, without overkilling things. There are packages that support multiple linters, but with Husky this is not needed.

image

Request to merge chore/husky-prettier-1807 into master
  • Email patches
  • Plain diff
Pipeline #80566708 failed for cd5adacb on chore/husky-prettier-1807
              Merge request approved. Approved by
              Mark Harding
              Mark Harding
              Brian Hatchet
              Brian Hatchet
              Guy Thouret
              Guy Thouret
              Olivia Madrid
              Olivia Madrid
              Juan Manuel Solaro
              Juan Manuel Solaro
              Emiliano Balbuena
              Emiliano Balbuena

              Merged by Mark Harding 54 minutes ago

              The changes were merged into master with dfcf7e79

              The source branch has been deleted

              Closed #1807 (closed)

              Pipeline #80569639 running for dfcf7e79 on master
                            • Discussion 0
                            • Commits 2
                            • Pipelines 8
                            • Changes 2
                            • Loading...
                            • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Green scoped labels 5 days ago

                              added MR::Awaiting Review Squad::Green scoped labels

                            • Ben Hayward @benhayward.ben added 1 commit 2 days ago

                              added 1 commit

                              • d12522da - Update package.json

                              Compare with previous version

                            • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 2 days ago

                              approved this merge request

                            • Martin Santangelo @msantang78 approved this merge request 5 hours ago

                              approved this merge request

                            • Ben Hayward @benhayward.ben added 1 commit 5 hours ago

                              added 1 commit

                              • ddecede7 - Update package.json

                              Compare with previous version

                            • Ben Hayward @benhayward.ben added 3 commits 4 hours ago

                              added 3 commits

                              • 65911cbc - Test
                              • d6805d66 - Merge branch 'chore/husky-prettier-1807' of gitlab.com:minds/front into chore/husky-prettier-1807
                              • 5b553897 - Added in pattern matching for extensions

                              Compare with previous version

                            • Ben Hayward @benhayward.ben added 1 commit 4 hours ago

                              added 1 commit

                              • d5a49019 - Added pattern match for file extensions to prettier check

                              Compare with previous version

                            • Ben Hayward @benhayward.ben added 1 commit 4 hours ago

                              added 1 commit

                              • 45319a80 - update:

                              Compare with previous version

                            • Ben Hayward @benhayward.ben added 16 commits 4 hours ago

                              added 16 commits

                              • 45319a80...e6c32aca - 15 commits from branch master
                              • a4b78f3c - Update

                              Compare with previous version

                            • Ben Hayward @benhayward.ben added 1 commit 1 hour ago

                              added 1 commit

                              • cd5adacb - Forgot to commit package-lock

                              Compare with previous version

                            • Mark Harding @markeharding approved this merge request 54 minutes ago

                              approved this merge request

                            • Mark Harding @markeharding merged 54 minutes ago

                              merged

                            • Mark Harding @markeharding mentioned in commit dfcf7e79 54 minutes ago

                              mentioned in commit dfcf7e79

                            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                            Please register or sign in to reply
                            0 Assignees
                            None
                            Assign to
                            None
                            Milestone
                            None
                            Assign milestone
                            None
                            Time tracking
                            No estimate or time spent
                            2
                            Labels
                            MR::Awaiting Review Squad::Green
                            Assign labels
                            • View project labels
                            Lock merge request
                            Unlocked
                            9
                            9 participants
                            user avatar
                            Brian Hatchet
                            user avatar
                            Guy Thouret
                            user avatar
                            Olivia Madrid
                            user avatar
                            Juan Manuel Solaro
                            user avatar
                            Emiliano Balbuena
                            user avatar
                            Martin Santangelo
                            user avatar
                            Marcelo Rivera
                            Reference: minds/front!532

                            Revert this merge request

                            This will create a new commit in order to revert the existing changes.

                            Switch branch
                            Cancel
                            A new branch will be created in your fork and a new merge request will be started.

                            Cherry-pick this merge request

                            Switch branch
                            Cancel
                            A new branch will be created in your fork and a new merge request will be started.