Brian Hatchet · @brianhatchet · f7700208 · Brian Hatchet · Brian Hatchet
--- a/Core/Permissions/Permissions.php
+++ b/Core/Permissions/Permissions.php
+ /** @var bool */ 
+ private $isBanned = false; 
+ /** @var User */ 
+ private $user; 
+ /** @var Roles */ 
+ private $roles; 
+ /** @var array */ 
+ private $entities; 
+ /** @var ChannelRoleCalculator */ 
+ private $channelRoleCalculator; 
+ /** @var GroupRoleCalculator */ 
+ private $groupRoleCalculator; 
+ /** @var EntitiesBuilder */ 
+ private $entitiesBuilder; 
+ 
+ public function setUser(User $user) 
--- a/Core/Permissions/Delegates/ChannelRoleCalculator.php
+++ b/Core/Permissions/Delegates/ChannelRoleCalculator.php
+class ChannelRoleCalculator extends BaseRoleCalculator 
+{ 
+ use MagicAttributes; 
+ 
+ private $channels = []; 
+ 
+ /** 
+ * Retrieves permissions for an entity relative to the user's role in a channel 
+ * Retrieves the role from the in memory cache if we've seen this channel before during this request 
+ * Else checks the user's membership against the channel. 
+ * 
+ * @param $entity an entity from a channel 
+ * 
+ * @return Role 
+ */ 
+ public function calculate($entity) 
--- a/Core/Permissions/Delegates/GroupRoleCalculator.php
+++ b/Core/Permissions/Delegates/GroupRoleCalculator.php
+ public function __construct(User $user, Roles $roles, EntitiesBuilder $entitiesBuilder = null) 
+ { 
+ parent::__construct($user, $roles); 
+ $this->entitiesBuilder = $entitiesBuilder ?: Di::_()->get('EntitiesBuilder'); 
+ } 
+ 
+ /** 
+ * Retrieves permissions for an entity relative to the user's role in a group 
+ * Retrieves the role from the in memory cache if we've seen this group before during this request 
+ * Else gets the group and checks the user's membership. 
+ * 
+ * @param $entity an entity belonging to a group 
+ * 
+ * @return Role 
+ */ 
+ public function calculate($entity) 
--- a/Core/Permissions/Entities/Manager.php
+++ b/Core/Permissions/Entities/Manager.php
+ public function __construct( 
+ EntitiesBuilder $entitiesBuilder = null, 
+ Call $db = null, 
+ Save $save = null) 
+ { 
+ $this->entitiesBuilder = $entitiesBuilder ?: Di::_()->get('EntitiesBuilder'); 
+ $this->db = $db ?: new Call('entities_by_time'); 
+ $this->save = $save ?: new Save(); //Mockable, else instantiate a new one on save. 
+ } 
+ 
+ /** 
+ * Save permissions for an entity and propegate it to linked objects 
+ * @param mixed $entity a minds entity that implements the save function 
+ * @param Permissions $permissions the flag to apply to the entity 
+ */ 
+ public function save($entity, EntityPermissions $permissions) 
--- a/Core/Permissions/Manager.php
+++ b/Core/Permissions/Manager.php
- 
 /** 
- * Save permissions for an entity and propegate it to linked objects 
- * @param mixed $entity a minds entity that implements the save function 
- * @param Permissions $permissions the flag to apply to the entity 
- */ 
- public function save($entity, Permissions $permissions) 
+ * Takes a user_guid and list of entity guids 
+ * Builds up a permissions object 
+ * Permissions contains the user's role per entity, channel and group 
+ * @param array $opts 
+ * - user_guid: long, the user's guid for calculating permissions 
+ * - guids: array long, the list of entities to permit 
+ * @return Permissions A map of channels, groups and entities with the user's role for each 
+ */ 
+ public function getList(array $opts = []) 
--- a/Core/Permissions/Permissions.php
+++ b/Core/Permissions/Permissions.php
+ private $roles; 
+ /** @var array */ 
+ private $entities; 
+ /** @var ChannelRoleCalculator */ 
+ private $channelRoleCalculator; 
+ /** @var GroupRoleCalculator */ 
+ private $groupRoleCalculator; 
+ /** @var EntitiesBuilder */ 
+ private $entitiesBuilder; 
+ 
+ public function setUser(User $user) 
+ { 
+ throw new ImmutableException('User can only be set in the constructor'); 
+ } 
+ 
+ public function __construct(User $user, Roles $roles = null, EntitiesBuilder $entitiesBuilder = null) 
--- a/Core/Permissions/Permissions.php
+++ b/Core/Permissions/Permissions.php
+ $this->entitiesBuilder = $entitiesBuilder ?: Di::_()->get('EntitiesBuilder'); 
+ $this->channels[$user->getGUID()] = $user; 
+ $this->channelRoleCalculator = new ChannelRoleCalculator($this->user, $this->roles); 
+ $this->groupRoleCalculator = new GroupRoleCalculator($this->user, $this->roles, $entitiesBuilder); 
+ } 
+ 
+ /** 
+ * Takes an array of entities and checks their permissions 
+ * Builds up collections of permissions based on the user's relationships to the entity 
+ * Any found channels and their roles are accessible in the channelRoleCalculator 
+ * Any found groups and their roles are in the groupRoleCalculator 
+ * All requested entities and the user's role is available in $this->entities. 
+ * 
+ * @param array entities an array of entities for calculating permissions 
+ */ 
+ public function calculate(array $entities = []) 
--- a/Core/Permissions/Permissions.php
+++ b/Core/Permissions/Permissions.php
+ * Takes an array of entities and checks their permissions 
+ * Builds up collections of permissions based on the user's relationships to the entity 
+ * Any found channels and their roles are accessible in the channelRoleCalculator 
+ * Any found groups and their roles are in the groupRoleCalculator 
+ * All requested entities and the user's role is available in $this->entities. 
+ * 
+ * @param array entities an array of entities for calculating permissions 
+ */ 
+ public function calculate(array $entities = []) 
+ { 
+ foreach ($entities as $entity) { 
+ $this->entities[$entity->getGUID()] = $this->getRoleForEntity($entity); 
+ } 
+ } 
+ 
+ private function getRoleForEntity($entity) 
--- a/Core/Permissions/Permissions.php
+++ b/Core/Permissions/Permissions.php
+ if ($this->isAdmin) { 
+ $role = $this->roles->getRole(Roles::ROLE_ADMIN); 
+ } 
+ if ($this->isBanned) { 
+ $role = $this->roles->getRole(Roles::ROLE_BANNED); 
+ } 
+ 
+ return $role; 
+ } 
+ 
+ /** 
+ * Export the nested objects. 
+ * 
+ * @return array serialized objects 
+ */ 
+ public function export() 
--- a/Core/Permissions/Permissions.php
+++ b/Core/Permissions/Permissions.php
+ */ 
+ public function export() 
+ { 
+ $export = []; 
+ $export['user'] = $this->user->export(); 
+ $export['channels'] = $this->getChannels(); 
+ $export['groups'] = $this->getGroups(); 
+ $export['entities'] = $this->entities; 
+ 
+ return $export; 
+ } 
+ 
+ /** 
+ * @return array channel guids with the user's role 
+ */ 
+ public function getChannels() 
--- a/Core/Permissions/Permissions.php
+++ b/Core/Permissions/Permissions.php
+ 
+ return $export; 
+ } 
+ 
+ /** 
+ * @return array channel guids with the user's role 
+ */ 
+ public function getChannels() 
+ { 
+ return $this->channelRoleCalculator->getChannels(); 
+ } 
+ 
+ /** 
+ * @return array group guids with the user's role 
+ */ 
+ public function getGroups() 
--- a/Core/Permissions/Permissions.php
+++ b/Core/Permissions/Permissions.php
+ { 
+ return $this->channelRoleCalculator->getChannels(); 
+ } 
+ 
+ /** 
+ * @return array group guids with the user's role 
+ */ 
+ public function getGroups() 
+ { 
+ return $this->groupRoleCalculator->getGroups(); 
+ } 
+ 
+ /** 
+ * @return array serialized objects 
+ */ 
+ public function jsonSerialize() 
--- a/Core/Permissions/Roles/BaseRole.php
+++ b/Core/Permissions/Roles/BaseRole.php
+<?php 
+ 
+namespace Minds\Core\Permissions\Roles; 
+ 
+use Zend\Permissions\Rbac; 
+ 
+abstract class BaseRole extends Rbac\Role implements \JsonSerializable 
+{ 
+ public function export() 
--- a/Core/Permissions/Manager.php
+++ b/Core/Permissions/Manager.php
 
- foreach ($this->db->getRow('activity:entitylink:'.$entity->getGUID()) as $parentGuid => $ts) { 
- $activity = $this->entitiesBuilder->single($parentGuid); 
- $activity->setAllowComments($permissions->getAllowComments()); 
- $this->save 
- ->setEntity($activity) 
- ->save(); 
+ $user = $this->entitiesBuilder->single($opts['user_guid']); 
+ $entities = $this->entitiesBuilder->get($opts); 
+ 
+ if ($user->getType() !== 'user') { 
+ throw new \InvalidArgumentException('Entity is not a user'); 
+ } 
+ 
+ /** @var Permissions */ 
+ $permissions = new Permissions($user, null, $entitiesBuilder);