Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 896
    • Issues 896
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 49
    • Merge Requests 49
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !536

Open
Opened 47 minutes ago by Guy Thouret@gthouret
  • Report abuse
Report abuse

(fix) Fix TypeError being thrown on window resize of new blog page

Easy fix for error being thrown - don't allow classList to be called null.

See #1777 for steps to recreate/test issue

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix/1777-typeerror origin/fix/1777-typeerror

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix/1777-typeerror

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/1777-typeerror into master
The source branch is 1 commit behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #80526934 passed with warnings for 66e47067 on fix/1777-typeerror
              Requires 2 more approvals from Devs and Deployers.
              Ben Hayward
              Ben Hayward
              Emiliano Balbuena
              Emiliano Balbuena
              Martin Santangelo
              Martin Santangelo
              Olivia Madrid
              Olivia Madrid
              Juan Manuel Solaro
              Juan Manuel Solaro
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Mentions #1777

              • Discussion 0
              • Commits 1
              • Pipelines 1
              • Changes 1
              • Loading...
              • Guy Thouret @gthouret changed milestone to %sprint: Modest Monkey 47 minutes ago

                changed milestone to %sprint: Modest Monkey

              • Guy Thouret @gthouret added MR::Awaiting Review Squad::Blue scoped labels 47 minutes ago

                added MR::Awaiting Review Squad::Blue scoped labels

              • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
              Please register or sign in to reply
              0 Assignees
              None
              Assign to
              sprint: Modest Monkey
              Milestone
              sprint: Modest Monkey
              Assign milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Awaiting Review Squad::Blue
              Assign labels
              • View project labels
              Lock merge request
              Unlocked
              9
              9 participants
              user avatar
              Ben Hayward
              user avatar
              Emiliano Balbuena
              user avatar
              Martin Santangelo
              user avatar
              Olivia Madrid
              user avatar
              Juan Manuel Solaro
              user avatar
              Mark Harding
              user avatar
              Brian Hatchet
              Reference: minds/front!536