Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 894
    • Issues 894
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 48
    • Merge Requests 48
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !499

Merged
Opened 2 weeks ago by Brian Hatchet@brianhatchet:speech_balloon:
  • Report abuse
Report abuse

Feat/closed channels 602

Adding the ability to mark channels open, closed and moderated

Right now this is just a widget that changes the channel mode on the epic.

Login. Go to your channel In the profile section, you should see a dropdown button that allows you to change between open, moderated and closed. Changing this box should persist across reloads.

If you go to another user's channel, that dropdown should be display only and you should not be able to change it unless you are the channel owner the logged in user

Edited 5 days ago by Brian Hatchet
Request to merge feat/closed-channels-602 into epic/permissions-open-channels
  • Email patches
  • Plain diff
Pipeline #80271876 passed for 39677bf9 on feat/closed-channels-602
              Merge request approved. Approved by
              Emiliano Balbuena
              Emiliano Balbuena
              Guy Thouret
              Guy Thouret
              Martin Santangelo
              Martin Santangelo
              Olivia Madrid
              Olivia Madrid
              Mark Harding
              Mark Harding
              Marcelo Rivera
              Marcelo Rivera

              Merged by Brian Hatchet 12 hours ago

              The changes were merged into epic/permissions-open-channels with fb452bc2

              The source branch has been deleted

              Pipeline #80343204 passed with warnings for fb452bc2 on epic/permissions-open-channels
                          • Discussion 12
                          • Commits 41
                          • Pipelines 27
                          • Changes 57
                          5/5 threads resolved
                          • Loading...
                          • Brian Hatchet :speech_balloon: @brianhatchet changed milestone to %sprint: Lucky Lizard 2 weeks ago

                            changed milestone to %sprint: Lucky Lizard

                          • Brian Hatchet :speech_balloon: @brianhatchet added Squad::Green scoped label 2 weeks ago

                            added Squad::Green scoped label

                          • Brian Hatchet :speech_balloon: @brianhatchet added 14 commits 2 weeks ago

                            added 14 commits

                            • ed5c797d - Sprint/KiltedKoala: Added in wire transaction e2e test #1641 (closed)
                            • bfd7f8ed - Merge branch 'feat/wire-e2e-1641' into 'master'
                            • fa9d8d65 - Sprint/KiltedKoala: Added in comment-tree e2e tests #1635 (closed)
                            • c55bb642 - Merge branch 'feat/comment-tree-e2e-1635' into 'master'
                            • 30f6bcee - Sprint/KiltedKoala: Added e2e tests for onboarding #1639 (closed)
                            • c3300d5b - Merge branch 'feat/onboarding-e2e-1639' into 'master'
                            • 442c8ce9 - Sprint/KiltedKoala: Added e2e tests for boost impressions #1634 (closed)
                            • ef9383fc - Merge branch 'feat/boost-impressions-1634' into 'master'
                            • 3c09991d - Sprint/KiltedKoala: Added e2e test for boost rejection in console #1633 (closed)
                            • 39b6fcb6 - Merge branch 'feat/boost-console-e2e-1633' into 'master'
                            • e98051fe - Sprint/KiltedKoala: Added in e2e for addition and deletion of remind. #1637 (closed)
                            • 268165b1 - Merge branch 'feat/remind-e2e-1637' into 'master'
                            • caaf44dd - Merge remote-tracking branch 'origin/master' into feat/closed-channels-602
                            • c6dcfe5b - Optimizing e2e tests

                            Compare with previous version

                            Toggle commit list
                          • Brian Hatchet :speech_balloon: @brianhatchet added 4 commits 2 weeks ago

                            added 4 commits

                            • 0d69d125 - Sprint/KiltedKoala: Media modal
                            • 13c6f471 - Merge branch 'feat/media-modal-1539' into 'master'
                            • 4d4b5217 - (chore): update media modal page
                            • 80b21460 - Merge remote-tracking branch 'origin/master' into feat/closed-channels-602

                            Compare with previous version

                            Toggle commit list
                          • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 2 weeks ago

                            added 1 commit

                            • 4157b7cf - Optimizing unit tests

                            Compare with previous version

                          • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

                            added 1 commit

                            • 0a7ad244 - Fixed test

                            Compare with previous version

                          • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

                            added 1 commit

                            • 851177c8 - missed somethign

                            Compare with previous version

                          • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 2 weeks ago

                            added 1 commit

                            • a3357f1a - Fixed tests up to groups

                            Compare with previous version

                          • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 2 weeks ago

                            added 1 commit

                            • 76dd3659 - Fixing before

                            Compare with previous version

                          • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

                            added 1 commit

                            • 57595be0 - Fixed flaking in newsfeed test

                            Compare with previous version

                          • Brian Hatchet :speech_balloon: @brianhatchet added 15 commits 2 weeks ago

                            added 15 commits

                            • ce8f950a - (fix): Boost marketing hero overlay correctly positioned
                            • 99603881 - (fix): user's own avatar not blurry on newsfeed
                            • 12fd31a8 - (chore): Stop tooltip cutoff on referrals dashboard on mobile
                            • 9c57ecf8 - Merge branch 'chore/referral-tooltip-cutoff-1552' into 'master'
                            • c71e2be4 - Sprint/LuckyLizard: Changed ng test reporter for clearer output.
                            • 7806119a - Merge branch 'chore/change-test-reporter-1745' into 'master'
                            • c70ca1f0 - Merge branch 'fix/blurry-avatar-1746' into 'master'
                            • 7ba536e1 - Sprint/LuckyLizard: Removed redirect on failed password reset.
                            • 8f58bb2e - Merge branch 'fix/password-reset-725' into 'master'
                            • 4a15081e - Merge branch 'fix/boost-mkting-overlay-1733' into 'master'
                            • 0e26962a - Sprint/KiltedKoala: Fix/video pause on rotate #1418
                            • e2eccb3a - Merge branch 'fix/video-pause-on-rotate-1418' into 'master'
                            • d52600d6 - Merge remote-tracking branch 'origin/master' into feat/closed-channels-602
                            • 497547a4 - Merge branch 'feat/closed-channels-602' of gitlab.com:minds/front into feat/closed-channels-602
                            • 2ed394f1 - Everything working edition

                            Compare with previous version

                            Toggle commit list
                          • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 2 weeks ago

                            added 1 commit

                            • 40381ea2 - Blog xhr routes

                            Compare with previous version

                          • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 2 weeks ago

                            added 1 commit

                            • 6e0ea629 - Removed a console log

                            Compare with previous version

                          • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 2 weeks ago

                            added 1 commit

                            • fbfe9770 - Added our project id to cypress. Removed timeouts

                            Compare with previous version

                          • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 2 weeks ago

                            added 1 commit

                            • 47614578 - Putting timeouts back

                            Compare with previous version

                          • Brian Hatchet :speech_balloon: @brianhatchet added 5 commits 1 week ago

                            added 5 commits

                            • 37ac7b64 - (rollback): Regression created where newsfeeds blow up - #1766 (closed)
                            • ec161448 - (feat): sentry for angular
                            • 2a24666e - (fix): do not throw error for missing entity, log in console
                            • 0cafd414 - Merge remote-tracking branch 'origin/master' into feat/closed-channels-602
                            • 324b0ded - Electron hates our file upload workaround. The npm package that addresses that...

                            Compare with previous version

                            Toggle commit list
                          • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 1 week ago

                            added 1 commit

                            • 706414c8 - Adding timeouts back

                            Compare with previous version

                          • Ben Hayward
                            Ben Hayward @benhayward.ben started a thread on an old version of the diff 1 week ago
                            Resolved by Brian Hatchet 1 week ago
                          • Ben Hayward
                            Ben Hayward @benhayward.ben started a thread on the diff 1 week ago
                            Resolved by Brian Hatchet 1 week ago
                          • Ben Hayward
                            Ben Hayward @benhayward.ben started a thread on an old version of the diff 1 week ago
                            Resolved by Brian Hatchet 1 week ago
                          • Ben Hayward
                            Ben Hayward @benhayward.ben started a thread on an old version of the diff 1 week ago
                            Resolved by Brian Hatchet 1 week ago
                          • Brian Hatchet :speech_balloon: @brianhatchet added 5 commits 1 week ago

                            added 5 commits

                            • 706414c8...6a48c5b1 - 4 commits from branch epic/permissions-open-channels
                            • 1c983fd9 - Merge remote-tracking branch 'origin/master' into feat/closed-channels-602

                            Compare with previous version

                          • Ben Hayward
                            Ben Hayward @benhayward.ben started a thread on an old version of the diff 1 week ago
                            Resolved by Brian Hatchet 1 week ago
                          • Brian Hatchet :speech_balloon: @brianhatchet resolved all threads 1 week ago

                            resolved all threads

                          • Brian Hatchet :speech_balloon: @brianhatchet resolved all threads 1 week ago

                            resolved all threads

                          • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 1 week ago

                            added 1 commit

                            • 3065c379 - CR changes

                            Compare with previous version

                          • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 1 week ago

                            added 1 commit

                            • 43db0d16 - Fixed test

                            Compare with previous version

                          • Brian Hatchet :speech_balloon: @brianhatchet added 8 commits 1 week ago

                            added 8 commits

                            • 43db0d16...357faf4a - 7 commits from branch epic/permissions-open-channels
                            • 152dc7a9 - Merge branch 'epic/permissions-open-channels' into feat/closed-channels-602

                            Compare with previous version

                          • Ben Hayward @benhayward.ben approved this merge request 1 week ago

                            approved this merge request

                          • Brian Hatchet :speech_balloon: @brianhatchet added 22 commits 6 days ago

                            added 22 commits

                            • 152dc7a9...c7759c2b - 20 commits from branch epic/permissions-open-channels
                            • 3281e790 - Prettier lint
                            • 239a4ba4 - Merge branch 'epic/permissions-open-channels' into feat/closed-channels-602

                            Compare with previous version

                          • Mark Harding
                            Mark Harding @markeharding · 5 days ago
                            Owner

                            Looks like the linter failed here.

                            prettier --write "src/**/*.ts"
                            prettier --write "src/**/*.scss"
                            prettier --write "src/**/*.html"
                          • Mark Harding @markeharding added MR::Requires Changes scoped label 5 days ago

                            added MR::Requires Changes scoped label

                          • Brian Hatchet :speech_balloon: @brianhatchet added 9 commits 5 days ago

                            added 9 commits

                            • 239a4ba4...72b331ec - 8 commits from branch epic/permissions-open-channels
                            • 034fc934 - Merge branch 'epic/permissions-open-channels' into feat/closed-channels-602

                            Compare with previous version

                          • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 5 days ago

                            added 1 commit

                            • cda9e1e7 - Linted

                            Compare with previous version

                          • Brian Hatchet :speech_balloon: @brianhatchet added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 5 days ago

                            added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label

                          • Brian Hatchet :speech_balloon: @brianhatchet changed the description 5 days ago

                            changed the description

                          • Brian Hatchet :speech_balloon: @brianhatchet added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 5 days ago

                            added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

                          • Brian Hatchet :speech_balloon: @brianhatchet added 2 commits 1 day ago

                            added 2 commits

                            • 5d0b9602 - Sprint/ModestMonkey: Updated commands and added utils and notification test base
                            • 02256ad4 - Merge branch 'feat/notification-e2e' into 'feat/closed-channels-602'

                            Compare with previous version

                          • Brian Hatchet :speech_balloon: @brianhatchet added 6 commits 1 day ago

                            added 6 commits

                            • 1458fa3f - (chore): further reduce rotator to 3
                            • 3d286cd9 - (chore): pass through version of frontend to XHR requests
                            • 0e4667c0 - (chore): refresh boost feed after each batch
                            • 0aec94c9 - (fix): cs fixes
                            • b17d9dad - Merge remote-tracking branch 'origin/master' into feat/closed-channels-602
                            • 1c38865e - Merge branch 'feat/closed-channels-602' of gitlab.com:minds/front into feat/closed-channels-602

                            Compare with previous version

                            Toggle commit list
                          • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 1 day ago

                            added 1 commit

                            • 88f598c2 - Fixing some more brittle tests

                            Compare with previous version

                          • Brian Hatchet :speech_balloon: @brianhatchet added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 18 hours ago

                            added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label

                          • Brian Hatchet :speech_balloon: @brianhatchet added 3 commits 18 hours ago

                            added 3 commits

                            • 5fe8f2b2 - Agnostic media modal
                            • 100602ee - Merge branch 'feat/media-modal-service-1822' into 'master'
                            • 39677bf9 - Merge remote-tracking branch 'origin/master' into feat/closed-channels-602

                            Compare with previous version

                          • Emiliano Balbuena @edgebal approved this merge request 16 hours ago

                            approved this merge request

                          • Brian Hatchet :speech_balloon: @brianhatchet mentioned in commit fb452bc2 12 hours ago

                            mentioned in commit fb452bc2

                          • Brian Hatchet :speech_balloon: @brianhatchet merged 12 hours ago

                            merged

                          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                          Please register or sign in to reply
                          Assignee
                          Brian Hatchet's avatar
                          Brian Hatchet @brianhatchet
                          Assign to
                          sprint: Lucky Lizard
                          Milestone
                          sprint: Lucky Lizard
                          Assign milestone
                          None
                          Time tracking
                          No estimate or time spent
                          2
                          Labels
                          MR::Awaiting Review Squad::Green
                          Assign labels
                          • View project labels
                          Lock merge request
                          Unlocked
                          9
                          9 participants
                          user avatar
                          Guy Thouret
                          user avatar
                          Martin Santangelo
                          user avatar
                          Olivia Madrid
                          user avatar
                          Mark Harding
                          user avatar
                          Marcelo Rivera
                          user avatar
                          Juan Manuel Solaro
                          user avatar
                          Ben Hayward
                          Reference: minds/front!499

                          Revert this merge request

                          This will create a new commit in order to revert the existing changes.

                          Switch branch
                          Cancel
                          A new branch will be created in your fork and a new merge request will be started.

                          Cherry-pick this merge request

                          Switch branch
                          Cancel
                          A new branch will be created in your fork and a new merge request will be started.