Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
M
Minds Embed
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Embed
  • Merge Requests
  • !1

Open
Opened 1 month ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

[Sprint/InterestingIguana] (feat): embeds site

closes engine#311

Edited 1 month ago by Marcelo Rivera

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feat/embeds-site origin/feat/embeds-site

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff feat/embeds-site

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/embeds-site into master
The source branch is 1 commit behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
No approval required
Ready to be merged automatically. Ask someone with write access to this repository to merge this request

Closes engine#311

  • Discussion 6
  • Commits 2
  • Changes 121
0/5 threads resolved
  • Loading...
  • Marcelo Rivera @eiennohi changed the description 1 month ago

    changed the description

  • Mark Harding
    Mark Harding @markeharding started a thread on an old version of the diff 1 month ago
    src/app/app.module.ts
    1 import { BrowserModule, Title } from '@angular/platform-browser';
    2 import { APP_INITIALIZER, NgModule } from '@angular/core';
    3
    4 import { AppComponent } from './app.component';
    5 import { VideoModule } from './modules/video/video.module';
    6 import { HttpClient, HttpClientModule } from '@angular/common/http';
    7 import { Client } from './services/client.service';
    • Mark Harding
      Mark Harding @markeharding · 1 month ago
      Owner

      Replace with angular http client

    • Please register or sign in to reply
  • Mark Harding
    Mark Harding @markeharding started a thread on an old version of the diff 1 month ago
    src/app/app.module.ts
    1 import { BrowserModule, Title } from '@angular/platform-browser';
    2 import { APP_INITIALIZER, NgModule } from '@angular/core';
    3
    4 import { AppComponent } from './app.component';
    5 import { VideoModule } from './modules/video/video.module';
    6 import { HttpClient, HttpClientModule } from '@angular/common/http';
    7 import { Client } from './services/client.service';
    8 import { WebtorrentService } from './modules/webtorrent/webtorrent.service';
    9 import { ScrollService } from './services/ux/scroll.service';
    • Mark Harding
      Mark Harding @markeharding · 1 month ago
      Owner

      perfect opportunity to move to common module

    • Please register or sign in to reply
  • Mark Harding
    Mark Harding @markeharding started a thread on an old version of the diff 1 month ago
    src/app/app.module.ts
    1 import { BrowserModule, Title } from '@angular/platform-browser';
    2 import { APP_INITIALIZER, NgModule } from '@angular/core';
    3
    4 import { AppComponent } from './app.component';
    5 import { VideoModule } from './modules/video/video.module';
    6 import { HttpClient, HttpClientModule } from '@angular/common/http';
    7 import { Client } from './services/client.service';
    8 import { WebtorrentService } from './modules/webtorrent/webtorrent.service';
    9 import { ScrollService } from './services/ux/scroll.service';
    10 import { CommonModule } from './modules/common/common.module';
    11 import { RouterModule } from '@angular/router';
    12 import { FormsModule, ReactiveFormsModule } from '@angular/forms';
    13 import { Storage } from './services/storage.service';
    14 import { MindsConfigurationService } from './services/minds-configurations.service';
    • Mark Harding
      Mark Harding @markeharding · 1 month ago
      Owner

      move to common

    • Please register or sign in to reply
  • Mark Harding
    Mark Harding @markeharding started a thread on an old version of the diff 1 month ago
    src/app/app.module.ts
    1 import { BrowserModule, Title } from '@angular/platform-browser';
    2 import { APP_INITIALIZER, NgModule } from '@angular/core';
    3
    4 import { AppComponent } from './app.component';
    5 import { VideoModule } from './modules/video/video.module';
    6 import { HttpClient, HttpClientModule } from '@angular/common/http';
    7 import { Client } from './services/client.service';
    8 import { WebtorrentService } from './modules/webtorrent/webtorrent.service';
    9 import { ScrollService } from './services/ux/scroll.service';
    10 import { CommonModule } from './modules/common/common.module';
    11 import { RouterModule } from '@angular/router';
    12 import { FormsModule, ReactiveFormsModule } from '@angular/forms';
    13 import { Storage } from './services/storage.service';
    14 import { MindsConfigurationService } from './services/minds-configurations.service';
    15 import { MindsTitle } from './services/ux/title';
    • Mark Harding
      Mark Harding @markeharding · 1 month ago
      Owner

      move to common

    • Please register or sign in to reply
  • Mark Harding
    Mark Harding @markeharding started a thread on an old version of the diff 1 month ago
    src/app/helpers/async-lock.ts
    1 import { BehaviorSubject, Subscription } from "rxjs";
    • Mark Harding
      Mark Harding @markeharding · 1 month ago
      Owner

      remove

    • Please register or sign in to reply
  • Fire Chief
    Fire Chief @onecrazychief · 1 hour ago

    When will this be available to end-users?

    How do we embed Minds feeds on external sites?

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
0 Assignees
None
Assign to
None
Milestone
None
Assign milestone
None
Time tracking
No estimate or time spent
0
Labels
None
Assign labels
  • View project labels
Lock merge request
Unlocked
3
3 participants
user avatar
Fire Chief
user avatar
Mark Harding
user avatar
Marcelo Rivera
Reference: minds/embed!1