Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 891
    • Issues 891
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 49
    • Merge Requests 49
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Issues
  • #1829

Closed
Open
Opened 1 week ago by Ben Hayward@benhayward.ben
  • Report abuse
  • New issue
Report abuse New issue

(bug): Tokens showing double after a withdrawal

Summary

I withdrew from offchain to onchain, note my receiver address and the onchain address are the same.. its counting it twice.

Steps to reproduce

  1. Set receiver address to your active metamask address if it isn't already (make a note of the old one for yourself)
  2. Make a withdrawal
  3. See the balance is counted twice

Platform information

Cross platform - web

What is the current bug behavior?

Onchain and reciever address are added together when they are the same address.

What is the expected correct behavior?

The value should be half this.

Relevant logs and/or screenshots

image image

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

Please solve the reCAPTCHA

We want to be sure it is you, please confirm you are not a robot.

Related issues
0

    • Discussion 8
    • Designs 0
    • Ben Hayward @benhayward.ben changed milestone to %sprint: Modest Monkey 1 week ago

      changed milestone to %sprint: Modest Monkey

    • Ben Hayward @benhayward.ben added Priority::1 - High Product::Wallet Type::Bug scoped labels 1 week ago

      added Priority::1 - High Product::Wallet Type::Bug scoped labels

    • Ben Hayward @benhayward.ben changed weight to 5 6 days ago

      changed weight to 5

    • Ben Hayward @benhayward.ben added Squad::Green scoped label 6 days ago

      added Squad::Green scoped label

    • Ben Hayward @benhayward.ben changed milestone to %sprint: Modest Monkey 5 days ago

      changed milestone to %sprint: Modest Monkey

    • Ben Hayward @benhayward.ben changed weight to 5 5 days ago

      changed weight to 5

    • Ben Hayward
      Ben Hayward @benhayward.ben · 1 hour ago
      Developer

      I think that we're not checking whether the receiver address is equal to the onchain address, and thus we're counting it twice?

    • Ben Hayward
      Ben Hayward @benhayward.ben · 45 minutes ago
      Developer

      There is actually a check for this here https://gitlab.com/minds/front/blob/master/src/app/modules/wallet/balances/tokens/balance.component.ts#L55

      Setting it up locally it works correctly.

      image

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply

    The one place for your designs

    Upload and view the latest designs for this issue. Consistent and easy to find, so everyone is up to date.

    Assignee
    Ben Hayward's avatar
    Ben Hayward @benhayward.ben
    Assign to
    none
    Epic
    None
    sprint: Modest Monkey
    Milestone
    sprint: Modest Monkey
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    None
    Due date
    None
    4
    Labels
    Priority::1 - High Product::Wallet Squad::Green Type::Bug
    Assign labels
    • View project labels
    5
    Weight
    5
    Confidentiality
    Not confidential
    Lock issue
    Unlocked
    1
    1 participant
    user avatar
    Ben Hayward
    Reference: minds/front#1829