Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 890
    • Issues 890
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 50
    • Merge Requests 50
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !492

Closed
Opened 3 weeks ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

WIP: [Sprint/KiltedKoala](feat) e2e tests for notification and cleanup functions

Closes #1687 and #1640

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feat/notification-e2e-1640 origin/feat/notification-e2e-1640

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff feat/notification-e2e-1640

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/notification-e2e-1640 into master
  • Email patches
  • Plain diff
Pipeline #78985228 canceled for d4941cdc on feat/notification-e2e-1640
              Requires 2 more approvals from Devs and Deployers.
              Guy Thouret
              Guy Thouret
              Emiliano Balbuena
              Emiliano Balbuena
              Juan Manuel Solaro
              Juan Manuel Solaro
              Brian Hatchet
              Brian Hatchet
              Marcelo Rivera
              Marcelo Rivera

              Closed by Ben Hayward 1 hour ago

              The changes were not merged into master

              Did not close #1640 and #1687

              Deletes source branch

              • Discussion 3
              • Commits 4
              • Pipelines 4
              • Changes 3
              • Loading...
              • Ben Hayward @benhayward.ben added 1 commit 3 weeks ago

                added 1 commit

                • 582b5a7b - notifs dont seem to be working properly on sandbox, need to figure that out

                Compare with previous version

              • Ben Hayward
                Ben Hayward @benhayward.ben · 3 weeks ago
                Developer

                Commented out after hook for now as with it in things cannot be debugged (cypress outputs that the test failed in the after hook if it fails anywhere).

                Notifications don't seem to be working for me on the sandbox.

                comment on user 2s post from user 1. User 2 receives no notification.

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet · 2 weeks ago
                Developer

                Don't disable tests if they are not working. That's a terrible habit to get into. We'll get the notifications fixed on sandbox when Mark is available tomorrow.

              • Ben Hayward
                Ben Hayward @benhayward.ben · 2 weeks ago
                Developer

                Oh I know. This is just a WIP. It's just this hook here: !492 (diffs)

                The reason is that if the test fails, it will always say that the error is in the after hook and not provide the correct failing section (when its actually in the tests). Because I was testing how it ran in the CI, I needed to leave it out so that I could actually get any outputted error.

              • Brian Hatchet :speech_balloon: @brianhatchet added 6 commits 2 weeks ago

                added 6 commits

                • 582b5a7b...14a72a8a - 5 commits from branch master
                • a8f3f663 - Merge remote-tracking branch 'origin/master' into feat/notification-e2e-1640

                Compare with previous version

              • Ben Hayward @benhayward.ben added 69 commits 4 days ago

                added 69 commits

                • a8f3f663...d69d2bd0 - 68 commits from branch master
                • d4941cdc - Merge branch 'master' of gitlab.com:minds/front into feat/notification-e2e-1640

                Compare with previous version

              • Ben Hayward @benhayward.ben closed 1 hour ago

                closed

              • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
              Please register or sign in to reply
              0 Assignees
              None
              Assign to
              None
              Milestone
              None
              Assign milestone
              None
              Time tracking
              No estimate or time spent
              0
              Labels
              None
              Assign labels
              • View project labels
              Lock merge request
              Unlocked
              9
              9 participants
              user avatar
              Guy Thouret
              user avatar
              Emiliano Balbuena
              user avatar
              Juan Manuel Solaro
              user avatar
              Brian Hatchet
              user avatar
              Marcelo Rivera
              user avatar
              Mark Harding
              user avatar
              Olivia Madrid
              Reference: minds/front!492