Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 890
    • Issues 890
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 50
    • Merge Requests 50
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !531

Open
Opened 3 days ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/ModestMonkey](fix): Return void if there is no selected or deselected image

Closes #1791

The issue is in the image embed, on image click. This is bound as an onclick event and if its firing on an image, and if e.target doesn't exist, we should just be returning void.

To test please go make a blog, add an image, click it, deselect etc.

Edited 3 days ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix/blogs-image-select-1791 origin/fix/blogs-image-select-1791

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix/blogs-image-select-1791

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/blogs-image-select-1791 into master
The source branch is 8 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #79793960 running for aa71ff28 on fix/blogs-image-select-1791
              Requires 2 more approvals from Devs and Deployers.
              Guy Thouret
              Guy Thouret
              Emiliano Balbuena
              Emiliano Balbuena
              Juan Manuel Solaro
              Juan Manuel Solaro
              Brian Hatchet
              Brian Hatchet
              Marcelo Rivera
              Marcelo Rivera
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #1791

              Deletes source branch

              • Discussion 4
              • Commits 4
              • Pipelines 5
              • Changes 1
              2/2 threads resolved
              • Loading...
              • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Green scoped labels 3 days ago

                added MR::Awaiting Review Squad::Green scoped labels

              • Ben Hayward @benhayward.ben changed the description 3 days ago

                changed the description

              • Ben Hayward
                Ben Hayward @benhayward.ben · 2 days ago
                Developer

                Note: failed pipeline is the cleanup pipeline.

              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 2 days ago
                Resolved by Ben Hayward 2 days ago
              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 2 days ago

                added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

              • Ben Hayward @benhayward.ben added 1 commit 2 days ago

                added 1 commit

                • e5238358 - Update embed-image.plugin.ts

                Compare with previous version

              • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 2 days ago

                added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label

              • Ben Hayward @benhayward.ben resolved all threads 2 days ago

                resolved all threads

              • Ben Hayward @benhayward.ben mentioned in issue #1813 2 hours ago

                mentioned in issue #1813

              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 1 hour ago
                Resolved by Ben Hayward 5 minutes ago
              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 hour ago

                added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

              • Ben Hayward @benhayward.ben added 1 commit 22 minutes ago

                added 1 commit

                • cbabacd1 - Updated for feedback

                Compare with previous version

              • Ben Hayward @benhayward.ben added 1 commit 6 minutes ago

                added 1 commit

                • aa71ff28 - Fixed null images causing error

                Compare with previous version

              • Ben Hayward @benhayward.ben resolved all threads 5 minutes ago

                resolved all threads

              • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 5 minutes ago

                added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label

              • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
              Please register or sign in to reply
              0 Assignees
              None
              Assign to
              None
              Milestone
              None
              Assign milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Awaiting Review Squad::Green
              Assign labels
              • View project labels
              Lock merge request
              Unlocked
              9
              9 participants
              user avatar
              Guy Thouret
              user avatar
              Emiliano Balbuena
              user avatar
              Juan Manuel Solaro
              user avatar
              Brian Hatchet
              user avatar
              Marcelo Rivera
              user avatar
              Mark Harding
              user avatar
              Olivia Madrid
              Reference: minds/front!531