(cache)[Sprint/ModestMonkey](fix): Return void if there is no selected or deselected image (!531) · Merge Requests · Minds / Minds Frontend · GitLab

[Sprint/ModestMonkey](fix): Return void if there is no selected or deselected image

Closes #1791

The issue is in the image embed, on image click. This is bound as an onclick event and if its firing on an image, and if e.target doesn't exist, we should just be returning void.

To test please go make a blog, add an image, click it, deselect etc.

Edited 1 day ago by Ben Hayward

Request to merge fix/blogs-image-select-1791 into master

The source branch is 7 commits behind the target branch

Open in Web IDE

1/1 thread resolved

Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Green scoped labels 1 day ago

added MR::Awaiting Review Squad::Green scoped labels
Ben Hayward @benhayward.ben changed the description 1 day ago

changed the description
Ben Hayward @benhayward.ben · 1 day ago

Developer

Note: failed pipeline is the cleanup pipeline.
Mark Harding @markeharding started a thread on an old version of the diff 1 day ago

Resolved by Ben Hayward 23 hours ago
Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 day ago

added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label
Ben Hayward @benhayward.ben added 1 commit 23 hours ago
added 1 commit

e5238358 - Update embed-image.plugin.ts

Compare with previous version
Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 23 hours ago

added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label
Ben Hayward @benhayward.ben resolved all threads 23 hours ago

resolved all threads
You're only seeing other activity in the feed. To add a comment, switch to one of the following options.

Please register or sign in to reply