[Sprint/ModestMonkey](fix): Return void if there is no selected or deselected image
Closes #1791
The issue is in the image embed, on image click. This is bound as an onclick event and if its firing on an image, and if e.target doesn't exist, we should just be returning void.
To test please go make a blog, add an image, click it, deselect etc.
0/1 thread resolved
added MR::Awaiting Review Squad::Green scoped labels
changed the description
- Developer
Note: failed pipeline is the cleanup pipeline.
227 230 return data; 228 231 } 229 232 233 /** 234 * On image select, responds to image click. 235 * @param { event } e - event from DOM. 236 */ 230 237 public selectImage(e) { 231 238 let $image = e.target; 239 240 if (!$image || $image.tagname) { - Owner
should be
!$image.tagName
?
added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label