Agnostic media modal
- Allows media modal to display more than just activity entities. Now can take objects (image/video/blog) too, so it can be used for Pro
- Display comment attachments in media modal
Closes #1822
TESTING:
- Tip: Click the 'view app' button on this MR page to get to the testing site.
Step 1: Do a bunch of media-related stuff with a test user account
- Make some posts that have image and video attachments (videos might not work if Mark hasn't enabled them in the staging environment yet)
- In the comment sections of those posts, add comments that have image and video attachments
- Some posts/comments should be accompanied with text titles/descriptions, others should just be a single media attachment without any words
- Remind one of the posts from the newsfeed
- Remind one of the posts from its media page
- Make a group and make an image/video comment in group chat
Step 2: Try to break it
- Go through your posts on a desktop and make sure they open the modal when you click on them
- Make sure the modal opens when you click on image/video comments from:
- The comments section of a post in your newsfeed
- The comments section of an open modal
- The comments section of a media page
- The comments section of a group chat
- Click the action buttons (wire/thumbs/remind)
- Do anything that isn't included in this list that I haven't thought of
- Do everything in the 'try to break it' section in:
- Chrome
- Brave
- Firefox
- Safari
- If you have access to a tablet, try that out too
Request to merge feat/media-modal-service-1822 into master
The source branch is 1 commit behind the target branch
0/1 thread resolved
added MR::Awaiting Review Product::Media Squad::Blue Type::Feature scoped labels
changed title from WIP: Feat/media modal service 1822 to WIP: Agnostic media modal
changed the description
unmarked as a Work In Progress
Reporterhey, whats the link to test this?
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
changed the description
249 this.stageWidth = this.mediaWidth; 250 this.modalWidth = this.stageWidth + this.contentWidth; 251 252 if (this.isLoading) { 253 this.isLoaded(); 254 } 255 256 return; 257 } 258 211 259 this.setHeightsAsTallAsPossible(); 212 260 213 261 // After heights are set, check that scaled width isn't too wide or narrow 214 262 this.maxStageWidth = Math.max( 215 window.innerWidth - this.contentWidth - this.padding * 2, 263 window.innerWidth - this.contentWidth + this.padding * 2, 
OwnerLooks like this should be a minus?