Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 888
    • Issues 888
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 48
    • Merge Requests 48
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !530

Open
Opened 1 hour ago by Olivia Madrid@omadrid
  • Report abuse
Report abuse

WIP: Agnostic media modal

Needs testing

  • Allows media modal to display more than just activity entities. Now can take objects (image/video/blog) too, so it can be used for Pro
  • Display comment attachments in media modal

Closes #1822

Edited 1 hour ago by Olivia Madrid

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feat/media-modal-service-1822 origin/feat/media-modal-service-1822

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff feat/media-modal-service-1822

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/media-modal-service-1822 into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #79372676 running for c7ad7185 on feat/media-modal-service-1822
              Requires 2 more approvals from Devs and Deployers.
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Juan Manuel Solaro
              Juan Manuel Solaro
              Guy Thouret
              Guy Thouret
              Ben Hayward
              Ben Hayward
              This is a Work in Progress

              Closes #1822

              You can merge this merge request manually using the
              • Discussion 0
              • Commits 8
              • Pipelines 5
              • Changes 20
              • Loading...
              • Olivia Madrid @omadrid added MR::Awaiting Review Product::Media Squad::Blue Type::Feature scoped labels 1 hour ago

                added MR::Awaiting Review Product::Media Squad::Blue Type::Feature scoped labels

              • Olivia Madrid @omadrid changed title from WIP: Feat/media modal service 1822 to WIP: Agnostic media modal 1 hour ago

                changed title from WIP: Feat/media modal service 1822 to WIP: Agnostic media modal

              • Olivia Madrid @omadrid changed the description 1 hour ago

                changed the description

              • Olivia Madrid @omadrid added 1 commit 1 hour ago

                added 1 commit

                • 855a4229 - (feat): more linting insanity

                Compare with previous version

              • Olivia Madrid @omadrid added 1 commit 47 minutes ago

                added 1 commit

                • 55b9ceb6 - (feat): remove an unused fx to pass tests

                Compare with previous version

              • Olivia Madrid @omadrid added 1 commit 33 minutes ago

                added 1 commit

                • 2b413e4a - (feat): escape from lint/test failure loop

                Compare with previous version

              • Olivia Madrid @omadrid added 1 commit 18 minutes ago

                added 1 commit

                • c7ad7185 - (feat): lint.

                Compare with previous version

              • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
              Please register or sign in to reply
              0 Assignees
              None
              Assign to
              None
              Milestone
              None
              Assign milestone
              None
              Time tracking
              No estimate or time spent
              4
              Labels
              MR::Awaiting Review Product::Media Squad::Blue Type::Feature
              Assign labels
              • View project labels
              Lock merge request
              Unlocked
              9
              9 participants
              user avatar
              Emiliano Balbuena
              user avatar
              Brian Hatchet
              user avatar
              Juan Manuel Solaro
              user avatar
              Guy Thouret
              user avatar
              Ben Hayward
              user avatar
              Marcelo Rivera
              user avatar
              Mark Harding
              Reference: minds/front!530