Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 888
    • Issues 888
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 47
    • Merge Requests 47
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !526

Open
Opened 1 day ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/ModestMonkey](feat): Added edit functionality to profile sidebar #1133

Closing #1133

To test, visit the sandbox, log in, go to your channel, edit your profile sidebar, edit the name

image image image

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feat/edit-name-sidebar-262 origin/feat/edit-name-sidebar-262

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff feat/edit-name-sidebar-262

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/edit-name-sidebar-262 into master
The source branch is 6 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #79228057 passed with warnings for 2420b908 on feat/edit-name-sidebar-262
              Requires 2 more approvals from Devs and Deployers.
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Juan Manuel Solaro
              Juan Manuel Solaro
              Guy Thouret
              Guy Thouret
              Marcelo Rivera
              Marcelo Rivera
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #1133

              Deletes source branch

              • Discussion 3
              • Commits 4
              • Pipelines 4
              • Changes 2
              1/2 threads resolved
              • Loading...
              • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Green scoped labels 1 day ago

                added MR::Awaiting Review Squad::Green scoped labels

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet started a thread on the diff 15 hours ago
                Resolved by Ben Hayward 14 hours ago
              • Ben Hayward @benhayward.ben added 3 commits 14 hours ago

                added 3 commits

                • f36d8ba6...d69d2bd0 - 2 commits from branch master
                • b37f4a54 - Merge branch 'master' of gitlab.com:minds/front into feat/edit-name-sidebar-262

                Compare with previous version

              • Ben Hayward @benhayward.ben added 1 commit 14 hours ago

                added 1 commit

                • 2420b908 - linting

                Compare with previous version

              • Ben Hayward @benhayward.ben resolved all threads 14 hours ago

                resolved all threads

              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 6 hours ago
                src/app/modules/channels/sidebar/sidebar.html
                5 5 (added)="upload_avatar($event)"
                6 6 ></minds-avatar>
                7 7 <div class="m-channel--name">
                8 <h2>{{user.name}}</h2>
                8 <h2 [hidden]="editing">{{user.name}}</h2>
                9 <div
                10 class="minds-editable-container mdl-card__supporting-text m-channel--name--editor"
                11 *ngIf="editing && isOwner()"
                12 >
                13 <textarea
                • Mark Harding
                  Mark Harding @markeharding · 6 hours ago
                  Owner

                  I think a name should just be an input field vs a textarea?

                • Please register or sign in to reply
              • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
              Please register or sign in to reply
              0 Assignees
              None
              Assign to
              None
              Milestone
              None
              Assign milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Awaiting Review Squad::Green
              Assign labels
              • View project labels
              Lock merge request
              Unlocked
              9
              9 participants
              user avatar
              Emiliano Balbuena
              user avatar
              Brian Hatchet
              user avatar
              Juan Manuel Solaro
              user avatar
              Guy Thouret
              user avatar
              Marcelo Rivera
              user avatar
              Olivia Madrid
              user avatar
              Mark Harding
              Reference: minds/front!526