WIP: epic/post-scheduler
3/10 threads resolved
- Owner
Excited about this! :)
added 1 commit
- 478bdc45 - (feat) blog linked activities should inherit time_created
- Resolved by Juan Manuel Solaro
added 2 commits
resolved all threads
added 1 commit
- b9e36ab7 - (feat) top feeds should be filter by created time
added 1 commit
- adc64ef1 - (fix) change spec it_should_not_save_when_previous_activity to...
added 1 commit
- d73a5a51 - (feat) filter activities by time_created to get scheduled
- Resolved by Juan Manuel Solaro
- Resolved by Juan Manuel Solaro
added 1 commit
- 54fe5e28 - (feat) ability to count scheduled activities
added 1 commit
- 2042213a - (test) add specs for scheduled manager and repository
added 1 commit
- 4fc1c30b - (fix) more than 3 months time created exception should be catched
added 23 commits
- f762c1f7...8e6942b6 - 22 commits from branch
master
- 34c8b96b - (fix) merge master into branch
- f762c1f7...8e6942b6 - 22 commits from branch
resolved all threads
resolved all threads
added 7 commits
- 5cf6c80a...514184e4 - 6 commits from branch
master
- 2bda8429 - Merge branch 'master' into epic/post-scheduler
- 5cf6c80a...514184e4 - 6 commits from branch
245 245 } 246 246 } 247 247 248 if (!$blog->isPublished()) { 249 $blog->setAccessId(Access::UNLISTED); 250 $blog->setDraftAccessId($_POST['access_id']); 251 } elseif ($blog->getTimePublished() == '') { - Developer
wouldn't it be better to do
!$blog->getTimePublished()
?
300 $timeCreatedDelegate->onUpdate($blog, $_POST['time_created'], time()); 301 } else { 302 $timeCreatedDelegate->onAdd($blog, $_POST['time_created'], time()); 303 } 304 } catch (\Exception $e) { 305 return Factory::response([ 306 'status' => 'error', 307 'message' => $e->getMessage(), 308 ]); 309 } 310 } 311 312 if (!$blog->isPublished()) { 313 $blog->setAccessId(Access::UNLISTED); 314 $blog->setDraftAccessId($_POST['access_id']); 315 } elseif ($blog->getTimePublished() == '') { - Developer
Wouldn't it be cleaner to do
!$blog->getTimePublished()
?
11 class TimeCreatedDelegate 12 { 13 /** @var Core\Feeds\Scheduled\EntityTimeCreated $entityTimeCreated */ 14 protected $entityTimeCreated; 15 16 /** 17 * TimeCreatedDelegate constructor. 18 * @param Save $save 19 */ 20 public function __construct() 21 { 22 $this->entityTimeCreated = new EntityTimeCreated(); 23 } 24 25 /** 26 * Validates time_created date and set it to activity - Developer
it should read "and sets it to activity"
32 'status' => 'error', 33 'message' => 'Invalid container', 34 ]); 35 } 36 37 $container = EntitiesFactory::build($container_guid); 38 39 if (!$container || !Core\Security\ACL::_()->read($container, $currentUser)) { 40 return Factory::response([ 41 'status' => 'error', 42 'message' => 'Forbidden', 43 ]); 44 } 45 46 $type = ''; 47 switch ($pages[1]) { - Developer
we could add a
default
case that throws a incorrect type exception, or something like that