Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 242
    • Issues 242
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 31
    • Merge Requests 31
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !112

Closed
Opened 5 months ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/Votes](bug): Defaulting notification prefix for comments

Addressing mobile-native#258 (closed)

Edited 4 months ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/engine.git notification-default-prefix-comments
git checkout -b benhayward.ben/engine-notification-default-prefix-comments FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/engine-notification-default-prefix-comments

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:notification-default-prefix-comments into master
  • Email patches
  • Plain diff
Pipeline #56374883 passed for b34e77dc on benhayward.ben:notification-default-prefix-comments
      Requires approval.

      Closed by Ben Hayward 5 hours ago

      The changes were not merged into master

      Allows commits from members who can merge to the target branch

      Mentions mobile-native#258 (closed)

      Deletes source branch

      • Discussion 9
      • Commits 7
      • Pipelines 6
      • Changes 2
      2/2 threads resolved
      • Loading...
      • Mark Harding
        Mark Harding @markeharding started a thread on an old version of the diff 5 months ago
        Resolved by Ben Hayward 5 months ago
      • Ben Hayward @benhayward.ben added 1 commit 5 months ago

        added 1 commit

        • 16ac45de - Update Push.php

        Compare with previous version

      • Ben Hayward @benhayward.ben resolved all discussions 5 months ago

        resolved all discussions

      • Mark Harding
        Mark Harding @markeharding started a thread on an old version of the diff 5 months ago
        Resolved by Ben Hayward 8 hours ago
      • Ben Hayward @benhayward.ben added 37 commits 4 months ago

        added 37 commits

        • 16ac45de...fe328ecf - 34 commits from branch minds:master
        • 3eb26a25 - Merge branch 'master' of gitlab.com:benhayward.ben/engine into notification-default-prefix-comments
        • c68a07eb - test
        • 1aa38e88 - WIP: uploading spec test

        Compare with previous version

        Toggle commit list
      • Ben Hayward @benhayward.ben marked as a Work In Progress from benhayward.ben/engine@1aa38e88 4 months ago

        marked as a Work In Progress from benhayward.ben/engine@1aa38e88

      • Ben Hayward @benhayward.ben added 1 commit 4 months ago

        added 1 commit

        • d9f19a71 - Update LegacyRepositorySpec.php

        Compare with previous version

      • Ben Hayward @benhayward.ben added 1 commit 4 months ago

        added 1 commit

        • 186b112b - Updated tests

        Compare with previous version

      • Ben Hayward @benhayward.ben added 1 commit 4 months ago

        added 1 commit

        • b34e77dc - Update LegacyRepositorySpec.php

        Compare with previous version

      • Ben Hayward @benhayward.ben unmarked as a Work In Progress 4 months ago

        unmarked as a Work In Progress

      • Mark Harding @markeharding added MR::Awaiting Review scoped label 1 month ago

        added MR::Awaiting Review scoped label

      • Mark Harding @markeharding added Squad::Green scoped label 1 month ago

        added Squad::Green scoped label

      • Ben Hayward @benhayward.ben resolved all threads 8 hours ago

        resolved all threads

      • Ben Hayward @benhayward.ben closed 5 hours ago

        closed

      • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
      Please register or sign in to reply
      0 Assignees
      None
      Assign to
      None
      Milestone
      None
      Assign milestone
      None
      Time tracking
      No estimate or time spent
      2
      Labels
      MR::Awaiting Review Squad::Green
      Assign labels
      • View project labels
      Lock merge request
      Unlocked
      2
      2 participants
      user avatar
      Ben Hayward
      user avatar
      Mark Harding
      Reference: minds/engine!112