Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 894
    • Issues 894
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 50
    • Merge Requests 50
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !262

Closed
Opened 4 months ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/BoisterousBuffalo](feat): Added in ability to edit name on profile sidebar

Closing #1133

Fixed the position of the edit button because it wasn't sitting quite right. This has no impact on responsiveness.

image image

EDIT:

Second commit moved it up slightly along with some tidying

image

Edited 4 months ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git edit-name-sidebar-feat
git checkout -b benhayward.ben/front-edit-name-sidebar-feat FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-edit-name-sidebar-feat

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:edit-name-sidebar-feat into master
  • Email patches
  • Plain diff
Pipeline #57601160 passed for 1de7ffa7 on benhayward.ben:edit-name-sidebar-feat
    Merge request approved. Approved by
    Marcelo Rivera
    Marcelo Rivera

    Closed by Ben Hayward 42 minutes ago

    The changes were not merged into master

    Allows commits from members who can merge to the target branch

    Did not close #1133

    Deletes source branch

    • Discussion 0
    • Commits 2
    • Pipelines 2
    • Changes 2
    • Loading...
    • Ben Hayward @benhayward.ben added 1 commit 4 months ago

      added 1 commit

      • 1de7ffa7 - A bit of tidying up

      Compare with previous version

    • Ben Hayward @benhayward.ben marked as a Work In Progress 4 months ago

      marked as a Work In Progress

    • Ben Hayward @benhayward.ben unmarked as a Work In Progress 4 months ago

      unmarked as a Work In Progress

    • Ben Hayward @benhayward.ben changed the description 2 times within 7 minutes 4 months ago

      changed the description 2 times within 7 minutes

    • Marcelo Rivera @eiennohi approved this merge request 2 months ago

      approved this merge request

    • Mark Harding @markeharding added MR::Awaiting Review scoped label 1 month ago

      added MR::Awaiting Review scoped label

    • Mark Harding @markeharding added Squad::Green scoped label 1 month ago

      added Squad::Green scoped label

    • Ben Hayward @benhayward.ben closed 42 minutes ago

      closed

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    0 Assignees
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    2
    Labels
    MR::Awaiting Review Squad::Green
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    2
    2 participants
    user avatar
    Ben Hayward
    user avatar
    Marcelo Rivera
    Reference: minds/front!262