Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 894
    • Issues 894
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 50
    • Merge Requests 50
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !370

Closed
Opened 2 months ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

(bug): Mobile web settings visual UI fixes #1360

Closes #1360

Wallet page:

image image

image image

image

Wire page overflow fixes:

image

Edited 2 months ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git mobile-web-settings-fix-1360
git checkout -b benhayward.ben/front-mobile-web-settings-fix-1360 FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-mobile-web-settings-fix-1360

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:mobile-web-settings-fix-1360 into master
  • Email patches
  • Plain diff
Pipeline #68163274 passed for 5f3fc436 on benhayward.ben:mobile-web-settings-fix-1360
    Requires approval from Devs. Approved by
    Marcelo Rivera
    Marcelo Rivera
    Martin Santangelo
    Martin Santangelo
    Brian Hatchet
    Brian Hatchet
    Emiliano Balbuena
    Emiliano Balbuena
    Mark Harding
    Mark Harding

    Closed by Ben Hayward 1 hour ago

    The changes were not merged into master

    Allows commits from members who can merge to the target branch

    Did not close #1360

    Deletes source branch

    • Discussion 0
    • Commits 7
    • Pipelines 7
    • Changes 5
    • Loading...
    • Ben Hayward @benhayward.ben added 1 commit 2 months ago

      added 1 commit

      • 6df5d9dc - Fixed wire screen issues

      Compare with previous version

    • Ben Hayward @benhayward.ben marked as a Work In Progress 2 months ago

      marked as a Work In Progress

    • Ben Hayward @benhayward.ben changed the description 2 times within 10 minutes 2 months ago

      changed the description 2 times within 10 minutes

    • Ben Hayward @benhayward.ben added 1 commit 2 months ago

      added 1 commit

      • 7cf130b6 - Quick fix to width

      Compare with previous version

    • Ben Hayward @benhayward.ben unmarked as a Work In Progress 2 months ago

      unmarked as a Work In Progress

    • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 2 months ago

      approved this merge request

    • Ben Hayward @benhayward.ben changed the description 2 months ago

      changed the description

    • Ben Hayward @benhayward.ben added 1 commit 2 months ago

      added 1 commit

      • de3006b5 - updates to wallet screen

      Compare with previous version

    • Ben Hayward @benhayward.ben added 1 commit 2 months ago

      added 1 commit

      • 3162b05f - removing undeeded change

      Compare with previous version

    • Ben Hayward @benhayward.ben added 1 commit 2 months ago

      added 1 commit

      • 5f3fc436 - removing undeeded change

      Compare with previous version

    • Marcelo Rivera @eiennohi approved this merge request 2 months ago

      approved this merge request

    • Mark Harding @markeharding added MR::Awaiting Review scoped label 1 month ago

      added MR::Awaiting Review scoped label

    • Mark Harding @markeharding added Squad::Green scoped label 1 month ago

      added Squad::Green scoped label

    • Ben Hayward @benhayward.ben closed 1 hour ago

      closed

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    0 Assignees
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    2
    Labels
    MR::Awaiting Review Squad::Green
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    6
    6 participants
    user avatar
    Martin Santangelo
    user avatar
    Brian Hatchet
    user avatar
    Emiliano Balbuena
    user avatar
    Mark Harding
    user avatar
    Ben Hayward
    user avatar
    Marcelo Rivera
    Reference: minds/front!370