Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 886
    • Issues 886
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 55
    • Merge Requests 55
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !524

Open
Opened 24 minutes ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/ModestMonkey](regression): Got rid of scrollbar and adjusted containers size accordingly.

Closes #1816

To test, create a group and go into it, spam the chat, try to break things, try resizing the window etc

image

Edited 13 minutes ago by Brian Hatchet

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b regression-grey-chat-bar-1816 origin/regression-grey-chat-bar-1816

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff regression-grey-chat-bar-1816

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge regression-grey-chat-bar-1816 into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #78940343 running for f338daea on regression-grey-chat-bar-1816
              Requires 2 more approvals from Devs and Deployers.
              Guy Thouret
              Guy Thouret
              Martin Santangelo
              Martin Santangelo
              Brian Hatchet
              Brian Hatchet
              Olivia Madrid
              Olivia Madrid
              Marcelo Rivera
              Marcelo Rivera
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #1816

              Deletes source branch

              • Discussion 1
              • Commits 1
              • Pipelines 1
              • Changes 1
              0/1 thread resolved
              • Loading...
              • Brian Hatchet :speech_balloon: @brianhatchet changed the description 13 minutes ago

                changed the description

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet started a thread on the diff 3 minutes ago
                src/app/modules/groups/profile/conversation/conversation.component.scss
                109 113 .mdl-card__actions {
                110 114 // top: 9px !important;
                111 115 }
                116 .m-comment--poster .minds-body {
                • Brian Hatchet
                  Brian Hatchet :speech_balloon: @brianhatchet · 3 minutes ago
                  Developer

                  Can you explain this change? This seems pretty dangerous

                • Please register or sign in to reply
              • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
              Please register or sign in to reply
              0 Assignees
              None
              Assign to
              None
              Milestone
              None
              Assign milestone
              None
              Time tracking
              No estimate or time spent
              0
              Labels
              None
              Assign labels
              • View project labels
              Lock merge request
              Unlocked
              9
              9 participants
              user avatar
              Guy Thouret
              user avatar
              Martin Santangelo
              user avatar
              Brian Hatchet
              user avatar
              Olivia Madrid
              user avatar
              Marcelo Rivera
              user avatar
              Emiliano Balbuena
              user avatar
              Juan Manuel Solaro
              Reference: minds/front!524