Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 886
    • Issues 886
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 54
    • Merge Requests 54
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !501

Open
Opened 1 week ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/LuckyLizard](fix) Boost console feed #1596

Closes #1596

Try the create boost button for the different pages here https://fix-boost-console-feed-1596.minds.io/boost/console/newsfeed/create

Edited 5 days ago by Brian Hatchet

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix/boost-console-feed-1596 origin/fix/boost-console-feed-1596

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix/boost-console-feed-1596

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/boost-console-feed-1596 into master
The source branch is 3 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #78713557 passed with warnings for 9a219148 on fix/boost-console-feed-1596
              Merge request approved. Approved by
              Brian Hatchet
              Brian Hatchet
              Guy Thouret
              Guy Thouret
              Martin Santangelo
              Martin Santangelo
              Olivia Madrid
              Olivia Madrid
              Marcelo Rivera
              Marcelo Rivera
              Emiliano Balbuena
              Emiliano Balbuena
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #1596

              Deletes source branch

              • Discussion 6
              • Commits 10
              • Pipelines 7
              • Changes 5
              1/2 threads resolved
              • Loading...
              • Ben Hayward @benhayward.ben added Squad::Green scoped label 1 week ago

                added Squad::Green scoped label

              • Ben Hayward @benhayward.ben added 1 commit 1 week ago

                added 1 commit

                • 3f7c0e7e - Fixed up tests and formatted

                Compare with previous version

              • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label 1 week ago

                added MR::Awaiting Review scoped label

              • Ben Hayward @benhayward.ben added 1 commit 1 week ago

                added 1 commit

                • db32dcc9 - Minor fix

                Compare with previous version

              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 1 week ago
                Resolved by Ben Hayward 4 days ago
              • Ben Hayward @benhayward.ben mentioned in issue #1596 6 days ago

                mentioned in issue #1596

              • Brian Hatchet :speech_balloon: @brianhatchet marked as a Work In Progress 5 days ago

                marked as a Work In Progress

              • Brian Hatchet :speech_balloon: @brianhatchet changed the description 5 days ago

                changed the description

              • Brian Hatchet :speech_balloon: @brianhatchet unmarked as a Work In Progress 5 days ago

                unmarked as a Work In Progress

              • Brian Hatchet
                Brian Hatchet :speech_balloon: @brianhatchet · 5 days ago
                Developer

                I tested this and it looks good. Once you address Mark's comment above, I will give it my approval.

                Edited by Brian Hatchet 5 days ago
              • Ben Hayward @benhayward.ben added 1 commit 4 days ago

                added 1 commit

                • 2deab016 - Updated endpoint for newsfeed

                Compare with previous version

              • Ben Hayward @benhayward.ben resolved all threads 4 days ago

                resolved all threads

              • Ben Hayward @benhayward.ben added 1 commit 4 days ago

                added 1 commit

                • 2a4f4f00 - Fixed failing tests

                Compare with previous version

              • Ben Hayward
                Ben Hayward @benhayward.ben · 4 days ago
                Developer

                Cool, we should be ready to go if you'd be so kind as to quickly test again

              • Brian Hatchet :speech_balloon: @brianhatchet added 53 commits 20 hours ago

                added 53 commits

                • 2a4f4f00...5ed6e576 - 52 commits from branch master
                • 9a219148 - Merge remote-tracking branch 'origin/master' into fix/boost-console-feed-1596

                Compare with previous version

              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 18 hours ago

                approved this merge request

              • Brian Hatchet :speech_balloon: @brianhatchet unapproved this merge request 18 hours ago

                unapproved this merge request

              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 15 hours ago

                approved this merge request

              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 40 minutes ago
                src/app/modules/boost/console/booster/booster.component.ts
                61 this.inProgress = false;
                62
                63 this.posts = responses[0].activity || [];
                64 this.media = responses[1].entities || [];
                65 // this.posts = [];
                66 // this.media = [];
                67 this.loadComponent();
                68 })
                69 .catch(e => {
                70 this.inProgress = false;
                71 return false;
                72 });
                70 this.feedsService
                71 .setEndpoint(
                72 this.type === 'content'
                73 ? 'api/v1/entities/owner'
                • Mark Harding
                  Mark Harding @markeharding · 40 minutes ago
                  Owner

                  I don't see how using api/v1/entities/owner solves the issue of new posts not showing at the top as they are being interpreted as string? Should this also not use api/v2/feeds/container...?

                • Please register or sign in to reply
              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 40 minutes ago

                added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

              • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
              Please register or sign in to reply
              0 Assignees
              None
              Assign to
              None
              Milestone
              None
              Assign milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Requires Changes Squad::Green
              Assign labels
              • View project labels
              Lock merge request
              Unlocked
              9
              9 participants
              user avatar
              Guy Thouret
              user avatar
              Martin Santangelo
              user avatar
              Olivia Madrid
              user avatar
              Marcelo Rivera
              user avatar
              Emiliano Balbuena
              user avatar
              Juan Manuel Solaro
              user avatar
              Mark Harding
              Reference: minds/front!501