Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 881
    • Issues 881
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 51
    • Merge Requests 51
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !498

Merged
Opened 1 week ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/LuckyLizard](fix): Fixed tablet bug causing chat to jump offscreen on scroll #1477

Closes #1477 (closed)

This was originally commented out by Mark in 24f09ff5 Looks to have been a minor visual adjustment made at the time, but its very hard to tell as much will have changed since then.

To test,

  1. Visit https://fix-tablet-chat-1477.minds.io/groups/profile/1005180701605105683/feed.
  2. Make your browser window tablet res, maybe somewhere around 800 x 500.
  3. Scroll down.
  4. See no jumping chat.
  5. Go ahead and try break the layout by resizing.
Request to merge fix/tablet-group-chat-1477 into master
  • Email patches
  • Plain diff
Pipeline #76443975 passed with warnings for c74a518a on fix/tablet-group-chat-1477
            Merge request approved. Approved by
            Martin Santangelo
            Martin Santangelo
            Brian Hatchet
            Brian Hatchet
            Marcelo Rivera
            Marcelo Rivera
            Juan Manuel Solaro
            Juan Manuel Solaro
            Mark Harding
            Mark Harding
            Olivia Madrid
            Olivia Madrid
            Emiliano Balbuena
            Emiliano Balbuena

            Merged by Brian Hatchet 1 hour ago

            The changes were merged into master with 9f4057ca

            The source branch has been deleted

            Closed #1477 (closed)

            Pipeline #78723967 waiting for manual action for 9f4057ca on master
                          • Discussion 1
                          • Commits 1
                          • Pipelines 1
                          • Changes 1
                          • Loading...
                          • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Green scoped labels 1 week ago

                            added MR::Awaiting Review Squad::Green scoped labels

                          • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 4 days ago

                            approved this merge request

                          • Brian Hatchet
                            Brian Hatchet :speech_balloon: @brianhatchet · 4 days ago
                            Developer

                            Confirmed, chat stays fixed on an ipad resolution and on an ipad / chrome

                          • Martin Santangelo @msantang78 approved this merge request 1 hour ago

                            approved this merge request

                          • Brian Hatchet :speech_balloon: @brianhatchet merged 1 hour ago

                            merged

                          • Brian Hatchet :speech_balloon: @brianhatchet mentioned in commit 9f4057ca 1 hour ago

                            mentioned in commit 9f4057ca

                          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                          Please register or sign in to reply
                          0 Assignees
                          None
                          Assign to
                          None
                          Milestone
                          None
                          Assign milestone
                          None
                          Time tracking
                          No estimate or time spent
                          2
                          Labels
                          MR::Awaiting Review Squad::Green
                          Assign labels
                          • View project labels
                          Lock merge request
                          Unlocked
                          9
                          9 participants
                          user avatar
                          Marcelo Rivera
                          user avatar
                          Juan Manuel Solaro
                          user avatar
                          Mark Harding
                          user avatar
                          Olivia Madrid
                          user avatar
                          Emiliano Balbuena
                          user avatar
                          Guy Thouret
                          user avatar
                          Brian Hatchet
                          Reference: minds/front!498

                          Revert this merge request

                          This will create a new commit in order to revert the existing changes.

                          Switch branch
                          Cancel
                          A new branch will be created in your fork and a new merge request will be started.

                          Cherry-pick this merge request

                          Switch branch
                          Cancel
                          A new branch will be created in your fork and a new merge request will be started.