Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 242
    • Issues 242
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 30
    • Merge Requests 30
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !251

Merged
Opened 1 month ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/InterestingIguana](feat): Offchain boost rate limiting #475

Closes #475 (closed)

May need to distribute off-chain tokens for staging, using the php-cli. php cli.php rewards issue --username=nemofin --amount=10000

image

Edited 1 month ago by Ben Hayward
Request to merge feat/rate-limit-boost-475 into master
  • Email patches
  • Plain diff
Pipeline #78721556 passed for 2a3cbd55 on feat/rate-limit-boost-475
          Merge request approved. Approved by
          Mark Harding
          Mark Harding
          Brian Hatchet
          Brian Hatchet
          Marcelo Rivera
          Marcelo Rivera
          Emiliano Balbuena
          Emiliano Balbuena
          Rami Albatal
          Rami Albatal
          Martin Santangelo
          Martin Santangelo

          Merged by Mark Harding 32 minutes ago

          The changes were merged into master with 514184e4

          The source branch has been deleted

          Closed #475 (closed)

          Pipeline #78723150 waiting for delayed job for 514184e4 on master
                      • Discussion 32
                      • Commits 17
                      • Pipelines 16
                      • Changes 5
                      19/19 threads resolved
                      • Loading...
                      • Ben Hayward
                        Ben Hayward @benhayward.ben · 1 month ago
                        Developer

                        Need to do some testing, and run this by somebody. Not 100% sure I've properly filtered down the transactions as the number coming out is not quite what I'd expect (though is close). Could be related to ES running under low disk constraints.

                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 1 month ago
                        Resolved by Ben Hayward 1 month ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 1 month ago
                        Resolved by Ben Hayward 1 month ago
                      • Mark Harding @markeharding added MR::Requires Changes scoped label 1 month ago

                        added MR::Requires Changes scoped label

                      • Ben Hayward @benhayward.ben added 2 commits 1 month ago

                        added 2 commits

                        • 6015b386 - Added in rate limits for offchain boosts.
                        • ad1bd20f - Updates, refactor and added tests

                        Compare with previous version

                      • Ben Hayward @benhayward.ben added 1 commit 1 month ago

                        added 1 commit

                        • 21f43ead - Updated, added in reduce for counting impressions and extra test

                        Compare with previous version

                      • Ben Hayward @benhayward.ben added 2 commits 1 month ago

                        added 2 commits

                        • 1e8d36d4 - spacing
                        • 3817cb1f - syntax

                        Compare with previous version

                      • Ben Hayward @benhayward.ben unmarked as a Work In Progress 1 month ago

                        unmarked as a Work In Progress

                      • Ben Hayward @benhayward.ben changed the description 1 month ago

                        changed the description

                      • Ben Hayward @benhayward.ben resolved all discussions 1 month ago

                        resolved all discussions

                      • Ben Hayward @benhayward.ben resolved all discussions 1 month ago

                        resolved all discussions

                      • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 1 month ago

                        added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label

                      • Ben Hayward @benhayward.ben mentioned in issue #591 1 month ago

                        mentioned in issue #591

                      • Ben Hayward @benhayward.ben mentioned in issue #592 1 month ago

                        mentioned in issue #592

                      • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 month ago

                        approved this merge request

                      • Marcelo Rivera @eiennohi approved this merge request 1 month ago

                        approved this merge request

                      • Ben Hayward
                        Ben Hayward @benhayward.ben · 1 month ago
                        Developer

                        @eiennohi @brianhatchet did you test with tokens? I was trying to get into this with kubectl to issue some to people. (this may have to wait till monday but if you haven't already got some, send me your usernames on staging)

                      • Mark Harding @markeharding added Squad::Green scoped label 1 month ago

                        added Squad::Green scoped label

                      • Ben Hayward
                        Ben Hayward @benhayward.ben · 1 month ago
                        Developer
                        1. boosted for 5000
                        2. boosted dif post for 4000
                        3. boosted dif post for 2000 - error
                        4. boosted for 1000 - success (max of 10k now reached)
                        5. boosted for 1000 - error

                        image

                      • Emiliano Balbuena
                        Emiliano Balbuena @edgebal started a thread on an old version of the diff 1 month ago
                        Resolved by Ben Hayward 1 month ago
                      • Ben Hayward @benhayward.ben added 1 commit 1 month ago

                        added 1 commit

                        • 2f37b154 - added in config for max

                        Compare with previous version

                      • Ben Hayward @benhayward.ben added 1 commit 1 month ago

                        added 1 commit

                        • 6c616c16 - added in config for max

                        Compare with previous version

                      • Ben Hayward @benhayward.ben resolved all threads 1 month ago

                        resolved all threads

                      • Ben Hayward @benhayward.ben added 1 commit 1 month ago

                        added 1 commit

                        • 9f3bcb40 - fixed failing tests

                        Compare with previous version

                      • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 4 weeks ago

                        approved this merge request

                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                        Resolved by Ben Hayward 3 weeks ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                        Resolved by Ben Hayward 3 weeks ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                        Resolved by Ben Hayward 3 weeks ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                        Resolved by Ben Hayward 3 weeks ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                        Resolved by Ben Hayward 3 weeks ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                        Resolved by Ben Hayward 3 weeks ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                        Resolved by Ben Hayward 3 weeks ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                        Resolved by Ben Hayward 3 weeks ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on the diff 3 weeks ago
                        Resolved by Ben Hayward 3 weeks ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                        Resolved by Ben Hayward 3 weeks ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                        Resolved by Ben Hayward 3 weeks ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                        Resolved by Ben Hayward 3 weeks ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                        Resolved by Ben Hayward 3 weeks ago
                      • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 3 weeks ago

                        added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

                      • Ben Hayward @benhayward.ben added 1 commit 3 weeks ago

                        added 1 commit

                        • 0cdeb613 - updated to meet feedback

                        Compare with previous version

                      • Ben Hayward @benhayward.ben added 1 commit 3 weeks ago

                        added 1 commit

                        • 38602fa9 - more feedback

                        Compare with previous version

                      • Ben Hayward @benhayward.ben resolved all threads 3 weeks ago

                        resolved all threads

                      • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 3 weeks ago

                        added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label

                      • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 3 weeks ago

                        added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

                      • Mark Harding
                        Mark Harding @markeharding · 3 weeks ago
                        Owner

                        failing tests

                      • Ben Hayward @benhayward.ben added 1 commit 3 weeks ago

                        added 1 commit

                        • 5358b5e3 - fixed test

                        Compare with previous version

                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                        Resolved by Ben Hayward 3 weeks ago
                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                        Resolved by Ben Hayward 3 weeks ago
                      • Ben Hayward @benhayward.ben added 1 commit 3 weeks ago

                        added 1 commit

                        • e8c67b01 - Updated to switch a function name and update reduce to have init index

                        Compare with previous version

                      • Ben Hayward @benhayward.ben resolved all threads 3 weeks ago

                        resolved all threads

                      • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 3 weeks ago

                        added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label

                      • Ben Hayward @benhayward.ben added 1 commit 3 weeks ago

                        added 1 commit

                        • ab303f91 - Updated tests with new function names

                        Compare with previous version

                      • Mark Harding
                        Mark Harding @markeharding started a thread on an old version of the diff 3 weeks ago
                        Resolved by Brian Hatchet 2 weeks ago
                      • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 3 weeks ago

                        added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label

                      • Ben Hayward @benhayward.ben added 1 commit 3 weeks ago

                        added 1 commit

                        • 08d1d75d - expanded from just review stage to all

                        Compare with previous version

                      • Ben Hayward @benhayward.ben added 2 commits 3 weeks ago

                        added 2 commits

                        • d735c585 - updated to only apply to active boosts and requests
                        • ac58cb96 - Fixing and updating tests

                        Compare with previous version

                      • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 3 weeks ago

                        added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label

                      • Ben Hayward @benhayward.ben resolved all threads 2 weeks ago

                        resolved all threads

                      • Brian Hatchet :speech_balloon: @brianhatchet resolved all threads 2 weeks ago

                        resolved all threads

                      • Mark Harding @markeharding added 161 commits 45 minutes ago

                        added 161 commits

                        • ac58cb96...365b8c4b - 160 commits from branch master
                        • 2a3cbd55 - Merge branch 'master' of gitlab.com:minds/engine into feat/rate-limit-boost-475

                        Compare with previous version

                      • Mark Harding @markeharding approved this merge request 33 minutes ago

                        approved this merge request

                      • Mark Harding @markeharding merged 33 minutes ago

                        merged

                      • Mark Harding @markeharding mentioned in commit 514184e4 33 minutes ago

                        mentioned in commit 514184e4

                      • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                      Please register or sign in to reply
                      0 Assignees
                      None
                      Assign to
                      None
                      Milestone
                      None
                      Assign milestone
                      None
                      Time tracking
                      No estimate or time spent
                      2
                      Labels
                      MR::Awaiting Review Squad::Green
                      Assign labels
                      • View project labels
                      Lock merge request
                      Unlocked
                      7
                      7 participants
                      user avatar
                      Brian Hatchet
                      user avatar
                      Marcelo Rivera
                      user avatar
                      Emiliano Balbuena
                      user avatar
                      Rami Albatal
                      user avatar
                      Martin Santangelo
                      user avatar
                      Mark Harding
                      user avatar
                      Ben Hayward
                      Reference: minds/engine!251

                      Revert this merge request

                      This will create a new commit in order to revert the existing changes.

                      Switch branch
                      Cancel
                      A new branch will be created in your fork and a new merge request will be started.

                      Cherry-pick this merge request

                      Switch branch
                      Cancel
                      A new branch will be created in your fork and a new merge request will be started.