Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 877
    • Issues 877
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 52
    • Merge Requests 52
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !518

Merged
Opened 16 hours ago by Mark Harding@markeharding
  • Report abuse
Report abuse

(chore): use pipeline id vs commit id

As demonstrated via 357faf4a, using $CI_BUILD_REF is DANGEROUS and can lead to conflicts. Making use of $CI_PIPELINE_ID keeps all the jobs in pipeline isolated.

Request to merge fix/use-pipeline-id-vs-commit into master
  • Email patches
  • Plain diff
Pipeline #78486240 canceled for 083fb0aa on fix/use-pipeline-id-vs-commit
              Merge request approved. Approved by
              Juan Manuel Solaro
              Juan Manuel Solaro
              Ben Hayward
              Ben Hayward
              Olivia Madrid
              Olivia Madrid
              Emiliano Balbuena
              Emiliano Balbuena
              Marcelo Rivera
              Marcelo Rivera
              Martin Santangelo
              Martin Santangelo
              Brian Hatchet
              Brian Hatchet

              Merged by Mark Harding 28 minutes ago

              The changes were merged into master with 5ed6e576

              The source branch has been deleted

              Pipeline #78624251 running for 5ed6e576 on master
                            • Discussion 0
                            • Commits 1
                            • Pipelines 2
                            • Changes 1
                            • Loading...
                            • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 16 hours ago

                              approved this merge request

                            • Mark Harding @markeharding added 1 commit 16 hours ago

                              added 1 commit

                              • 083fb0aa - (chore): use pipeline id vs commit id

                              Compare with previous version

                            • Ben Hayward @benhayward.ben approved this merge request 49 minutes ago

                              approved this merge request

                            • Juan Manuel Solaro @juanmsolaro approved this merge request 38 minutes ago

                              approved this merge request

                            • Mark Harding @markeharding merged 28 minutes ago

                              merged

                            • Mark Harding @markeharding mentioned in commit 5ed6e576 28 minutes ago

                              mentioned in commit 5ed6e576

                            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                            Please register or sign in to reply
                            0 Assignees
                            None
                            Assign to
                            None
                            Milestone
                            None
                            Assign milestone
                            None
                            Time tracking
                            No estimate or time spent
                            0
                            Labels
                            None
                            Assign labels
                            • View project labels
                            Lock merge request
                            Unlocked
                            9
                            9 participants
                            user avatar
                            Olivia Madrid
                            user avatar
                            Emiliano Balbuena
                            user avatar
                            Marcelo Rivera
                            user avatar
                            Martin Santangelo
                            user avatar
                            Brian Hatchet
                            user avatar
                            Guy Thouret
                            user avatar
                            Mark Harding
                            Reference: minds/front!518

                            Revert this merge request

                            This will create a new commit in order to revert the existing changes.

                            Switch branch
                            Cancel
                            A new branch will be created in your fork and a new merge request will be started.

                            Cherry-pick this merge request

                            Switch branch
                            Cancel
                            A new branch will be created in your fork and a new merge request will be started.