Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 876
    • Issues 876
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 53
    • Merge Requests 53
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !518

Open
Opened 1 hour ago by Mark Harding@markeharding
  • Report abuse
Report abuse

(chore): use pipeline id vs commit id

As demonstrated via 357faf4a, using $CI_BUILD_REF is DANGEROUS and can lead to conflicts. Making use of $CI_PIPELINE_ID keeps all the jobs in pipeline isolated.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix/use-pipeline-id-vs-commit origin/fix/use-pipeline-id-vs-commit

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix/use-pipeline-id-vs-commit

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/use-pipeline-id-vs-commit into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #78486240 running for 083fb0aa on fix/use-pipeline-id-vs-commit
              Requires 2 more approvals from Devs and Deployers.
              Martin Santangelo
              Martin Santangelo
              Emiliano Balbuena
              Emiliano Balbuena
              Ben Hayward
              Ben Hayward
              Olivia Madrid
              Olivia Madrid
              Guy Thouret
              Guy Thouret
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Deletes source branch

              • Discussion 0
              • Commits 1
              • Pipelines 2
              • Changes 1
              • Loading...
              • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 hour ago

                approved this merge request

              • Mark Harding @markeharding added 1 commit 21 minutes ago

                added 1 commit

                • 083fb0aa - (chore): use pipeline id vs commit id

                Compare with previous version

              • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
              Please register or sign in to reply
              0 Assignees
              None
              Assign to
              None
              Milestone
              None
              Assign milestone
              None
              Time tracking
              No estimate or time spent
              0
              Labels
              None
              Assign labels
              • View project labels
              Lock merge request
              Unlocked
              9
              9 participants
              user avatar
              Martin Santangelo
              user avatar
              Emiliano Balbuena
              user avatar
              Ben Hayward
              user avatar
              Olivia Madrid
              user avatar
              Guy Thouret
              user avatar
              Marcelo Rivera
              user avatar
              Brian Hatchet
              Reference: minds/front!518