Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 241
    • Issues 241
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 31
    • Merge Requests 31
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !295

Merged
Opened 1 week ago by Brian Hatchet@brianhatchet:speech_balloon:
  • Report abuse
Report abuse

Feat/closed channels 602

Request to merge feat/closed-channels-602 into epic/permissions-open-channels
  • Email patches
  • Plain diff
Pipeline #78437828 passed for e4d27bc1 on feat/closed-channels-602
          Merge request approved. Approved by
          Mark Harding
          Mark Harding
          Martin Santangelo
          Martin Santangelo
          Emiliano Balbuena
          Emiliano Balbuena
          Ben Hayward
          Ben Hayward
          Marcelo Rivera
          Marcelo Rivera
          Rami Albatal
          Rami Albatal

          Merged by Mark Harding 3 hours ago

          The changes were merged into epic/permissions-open-channels with f90ffda3

          The source branch has been deleted

          Pipeline #78455849 passed for f90ffda3 on epic/permissions-open-channels
                  • Discussion 5
                  • Commits 21
                  • Pipelines 9
                  • Changes 7
                  1/2 threads resolved
                  • Loading...
                  • Brian Hatchet :speech_balloon: @brianhatchet changed milestone to %sprint: Lucky Lizard 1 week ago

                    changed milestone to %sprint: Lucky Lizard

                  • Brian Hatchet :speech_balloon: @brianhatchet added Squad::Green scoped label 1 week ago

                    added Squad::Green scoped label

                  • Brian Hatchet
                    Brian Hatchet :speech_balloon: @brianhatchet · 1 week ago
                    Developer

                    This will be a lot smaller once the underlying rbac gets approved and merged into the epic

                  • Brian Hatchet :speech_balloon: @brianhatchet added 3 commits 1 week ago

                    added 3 commits

                    • 80dd6482...37f3f45b - 2 commits from branch epic/permissions-open-channels
                    • bc374153 - Merge remote-tracking branch 'origin/master' into feat/closed-channels-602

                    Compare with previous version

                  • Brian Hatchet :speech_balloon: @brianhatchet added 5 commits 1 week ago

                    added 5 commits

                    • a30be7ad - Merge remote-tracking branch 'origin/master' into feature/permissions-rbac-600
                    • e86be901 - Immutable exception when trying to set a user in permissions
                    • 15d548b5 - Proper refactor of entitiesBuilder injection
                    • 505458cc - Typo fix
                    • c6687670 - Merge branch 'feature/permissions-rbac-600' into feat/closed-channels-602

                    Compare with previous version

                    Toggle commit list
                  • Brian Hatchet :speech_balloon: @brianhatchet added 6 commits 5 days ago

                    added 6 commits

                    • 022020ca - (feat) Add contribution values to wallet overview api - #746
                    • 5a1ef698 - (chore): Bot prevention in phone number
                    • f0a2ec8a - (chore): log all 2fa SMS messages
                    • 3a730050 - Merge branch 'feat/746-wallet-api' into 'master'
                    • 646eb771 - (chore): bump surge package
                    • d27bdfae - Merge remote-tracking branch 'origin/master' into feat/closed-channels-602

                    Compare with previous version

                    Toggle commit list
                  • Brian Hatchet :speech_balloon: @brianhatchet added 4 commits 5 days ago

                    added 4 commits

                    • d27bdfae...f1a95d84 - 3 commits from branch epic/permissions-open-channels
                    • 022f3024 - Merge branch 'epic/permissions-open-channels' into feat/closed-channels-602

                    Compare with previous version

                  • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 5 days ago

                    added 1 commit

                    • c39461b8 - Fixed a bug checking mode 0 on the api

                    Compare with previous version

                  • Brian Hatchet :speech_balloon: @brianhatchet added 12 commits 3 days ago

                    added 12 commits

                    • c39461b8...99e9daf9 - 11 commits from branch epic/permissions-open-channels
                    • 5f995cdc - Merge branch 'epic/permissions-open-channels' into feat/closed-channels-602

                    Compare with previous version

                  • Mark Harding
                    Mark Harding @markeharding started a thread on an old version of the diff 8 hours ago
                    Last updated by Brian Hatchet 5 hours ago
                    Common/ChannelMode.php
                    1 <?php
                    2
                    3 namespace Minds\Common;
                    4 use ReflectionClass;
                    5
                    6 abstract class ChannelMode
                    7 {
                    8 const OPEN = 0;
                    9 const MODERATED = 1;
                    10 const CLOSED = 2;
                    11
                    12 final public static function toArray()
                    • Mark Harding
                      Mark Harding @markeharding · 8 hours ago
                      Owner

                      can we get some data types in eg: toArray() : array and isValid() : bool?

                    • Brian Hatchet
                      Brian Hatchet :speech_balloon: @brianhatchet · 5 hours ago
                      Developer

                      Added and will do so from now on

                    • Brian Hatchet :speech_balloon: @brianhatchet changed this line in version 10 of the diff 5 hours ago

                      changed this line in version 10 of the diff

                    • Please register or sign in to reply
                  • Mark Harding
                    Mark Harding @markeharding started a thread on an old version of the diff 8 hours ago
                    Resolved by Brian Hatchet 5 hours ago
                  • Brian Hatchet :speech_balloon: @brianhatchet added 4 commits 7 hours ago

                    added 4 commits

                    • 5f995cdc...b007ed64 - 3 commits from branch epic/permissions-open-channels
                    • 50bbd9bd - Merge branch 'epic/permissions-open-channels' into feat/closed-channels-602

                    Compare with previous version

                  • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 5 hours ago

                    added 1 commit

                    • e4d27bc1 - MR review changes

                    Compare with previous version

                  • Mark Harding @markeharding approved this merge request 4 hours ago

                    approved this merge request

                  • Mark Harding @markeharding merged 3 hours ago

                    merged

                  • Mark Harding @markeharding mentioned in commit f90ffda3 3 hours ago

                    mentioned in commit f90ffda3

                  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                  Please register or sign in to reply
                  Assignee
                  Brian Hatchet's avatar Brian Hatchet @brianhatchet
                  Assign to
                  sprint: Lucky Lizard
                  Milestone
                  sprint: Lucky Lizard
                  Assign milestone
                  None
                  Time tracking
                  No estimate or time spent
                  1
                  Labels
                  Squad::Green
                  Assign labels
                  • View project labels
                  Lock merge request
                  Unlocked
                  7
                  7 participants
                  user avatar
                  Martin Santangelo
                  user avatar
                  Emiliano Balbuena
                  user avatar
                  Ben Hayward
                  user avatar
                  Marcelo Rivera
                  user avatar
                  Rami Albatal
                  user avatar
                  Brian Hatchet
                  user avatar
                  Mark Harding
                  Reference: minds/engine!295

                  Revert this merge request

                  This will create a new commit in order to revert the existing changes.

                  Switch branch
                  Cancel
                  A new branch will be created in your fork and a new merge request will be started.

                  Cherry-pick this merge request

                  Switch branch
                  Cancel
                  A new branch will be created in your fork and a new merge request will be started.