Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 876
    • Issues 876
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 51
    • Merge Requests 51
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !513

Merged
Opened 2 days ago by Olivia Madrid@omadrid
  • Report abuse
Report abuse

[Sprint/LuckyLizard](fix): Stop media modals in mobile

Media modals were opening in mobile but aren't anymore. Also fixed extra toggle firing in media page video player when clicking control bar.

Closes #1800 (closed) and #1780 (closed)

Request to merge fix/no-mobile-modal-1800 into master
  • Email patches
  • Plain diff
Pipeline #78143614 passed with warnings for 174cfdcb on fix/no-mobile-modal-1800
            Merge request approved. Approved by
            Mark Harding
            Mark Harding
            Martin Santangelo
            Martin Santangelo
            Emiliano Balbuena
            Emiliano Balbuena
            Ben Hayward
            Ben Hayward
            Juan Manuel Solaro
            Juan Manuel Solaro
            Guy Thouret
            Guy Thouret

            Merged by Mark Harding 46 minutes ago

            The changes were merged into master with 07a087a5

            The source branch has been deleted

            Closed #1780 (closed) and #1800 (closed)

            Pipeline #78438591 running for 07a087a5 on master
                          • Discussion 1
                          • Commits 2
                          • Pipelines 2
                          • Changes 7
                          • Loading...
                          • Mark Harding
                            Mark Harding @markeharding · 2 days ago
                            Owner

                            Also on rubbersoul for testing

                          • Mark Harding @markeharding approved this merge request 2 days ago

                            approved this merge request

                          • Mark Harding @markeharding mentioned in commit 07a087a5 46 minutes ago

                            mentioned in commit 07a087a5

                          • Mark Harding @markeharding merged 46 minutes ago

                            merged

                          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
                          Please register or sign in to reply
                          0 Assignees
                          None
                          Assign to
                          None
                          Milestone
                          None
                          Assign milestone
                          None
                          Time tracking
                          No estimate or time spent
                          0
                          Labels
                          None
                          Assign labels
                          • View project labels
                          Lock merge request
                          Unlocked
                          9
                          9 participants
                          user avatar
                          Martin Santangelo
                          user avatar
                          Emiliano Balbuena
                          user avatar
                          Ben Hayward
                          user avatar
                          Juan Manuel Solaro
                          user avatar
                          Guy Thouret
                          user avatar
                          Marcelo Rivera
                          user avatar
                          Brian Hatchet
                          Reference: minds/front!513

                          Revert this merge request

                          This will create a new commit in order to revert the existing changes.

                          Switch branch
                          Cancel
                          A new branch will be created in your fork and a new merge request will be started.

                          Cherry-pick this merge request

                          Switch branch
                          Cancel
                          A new branch will be created in your fork and a new merge request will be started.