Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 876
    • Issues 876
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 53
    • Merge Requests 53
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !513

Open
Opened 10 hours ago by Olivia Madrid@omadrid
  • Report abuse
Report abuse

[Sprint/LuckyLizard](fix): Stop media modals in mobile

Media modals were opening in mobile but aren't anymore. Also fixed extra toggle firing in media page video player when clicking control bar.

Closes #1800 and #1780

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix/no-mobile-modal-1800 origin/fix/no-mobile-modal-1800

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix/no-mobile-modal-1800

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/no-mobile-modal-1800 into master
The source branch is 2 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #78143614 passed with warnings for 174cfdcb on fix/no-mobile-modal-1800
            Merge request approved. Approved by
            Mark Harding
            Mark Harding
            Emiliano Balbuena
            Emiliano Balbuena
            Martin Santangelo
            Martin Santangelo
            Brian Hatchet
            Brian Hatchet
            Ben Hayward
            Ben Hayward
            Guy Thouret
            Guy Thouret
            Ready to be merged automatically. Ask someone with write access to this repository to merge this request

            Closes #1780 and #1800

            • Discussion 1
            • Commits 2
            • Pipelines 2
            • Changes 7
            • Loading...
            • Mark Harding
              Mark Harding @markeharding · 6 hours ago
              Owner

              Also on rubbersoul for testing

            • Mark Harding @markeharding approved this merge request 6 hours ago

              approved this merge request

            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
            Please register or sign in to reply
            0 Assignees
            None
            Assign to
            None
            Milestone
            None
            Assign milestone
            None
            Time tracking
            No estimate or time spent
            0
            Labels
            None
            Assign labels
            • View project labels
            Lock merge request
            Unlocked
            9
            9 participants
            user avatar
            Emiliano Balbuena
            user avatar
            Martin Santangelo
            user avatar
            Brian Hatchet
            user avatar
            Ben Hayward
            user avatar
            Guy Thouret
            user avatar
            Marcelo Rivera
            user avatar
            Juan Manuel Solaro
            Reference: minds/front!513