Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 876
    • Issues 876
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 53
    • Merge Requests 53
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !498

Open
Opened 1 week ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/LuckyLizard](fix): Fixed tablet bug causing chat to jump offscreen on scroll #1477

Closes #1477

This was originally commented out by Mark in 24f09ff5 Looks to have been a minor visual adjustment made at the time, but its very hard to tell as much will have changed since then.

To test,

  1. Visit https://fix-tablet-chat-1477.minds.io/groups/profile/1005180701605105683/feed.
  2. Make your browser window tablet res, maybe somewhere around 800 x 500.
  3. Scroll down.
  4. See no jumping chat.
  5. Go ahead and try break the layout by resizing.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix/tablet-group-chat-1477 origin/fix/tablet-group-chat-1477

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix/tablet-group-chat-1477

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/tablet-group-chat-1477 into master
The source branch is 40 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #76443975 passed with warnings for c74a518a on fix/tablet-group-chat-1477
            Merge request approved. Approved by
            Brian Hatchet
            Brian Hatchet
            Emiliano Balbuena
            Emiliano Balbuena
            Martin Santangelo
            Martin Santangelo
            Marcelo Rivera
            Marcelo Rivera
            Olivia Madrid
            Olivia Madrid
            Guy Thouret
            Guy Thouret
            Ready to be merged automatically. Ask someone with write access to this repository to merge this request

            Closes #1477

            Deletes source branch

            • Discussion 1
            • Commits 1
            • Pipelines 1
            • Changes 1
            • Loading...
            • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Green scoped labels 1 week ago

              added MR::Awaiting Review Squad::Green scoped labels

            • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 hour ago

              approved this merge request

            • Brian Hatchet
              Brian Hatchet :speech_balloon: @brianhatchet · 16 minutes ago
              Developer

              Confirmed, chat stays fixed on an ipad resolution and on an ipad / chrome

            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
            Please register or sign in to reply
            0 Assignees
            None
            Assign to
            None
            Milestone
            None
            Assign milestone
            None
            Time tracking
            No estimate or time spent
            2
            Labels
            MR::Awaiting Review Squad::Green
            Assign labels
            • View project labels
            Lock merge request
            Unlocked
            9
            9 participants
            user avatar
            Emiliano Balbuena
            user avatar
            Martin Santangelo
            user avatar
            Marcelo Rivera
            user avatar
            Olivia Madrid
            user avatar
            Guy Thouret
            user avatar
            Juan Manuel Solaro
            user avatar
            Mark Harding
            Reference: minds/front!498