0/3 threads resolved
added 1 commit
- a9df951b - (fix): import featuresServiceMock to pass tests
marked as a Work In Progress
changed the description
added 10 commits
- d32fbf54...c4f8e4b0 - 6 commits from branch
master
- 1eafe83c - Merge branch 'master' of gitlab.com:minds/front into fix/video-play-outside-canary-1761
- d41756c0 - Merge branch 'master' of gitlab.com:minds/front into fix/video-play-outside-canary-1761
- 222cb073 - (fix): cross browser fullscreen works
- a1032494 - Merge branch 'master' of gitlab.com:minds/front into fix/video-play-outside-canary-1761
Toggle commit list- d32fbf54...c4f8e4b0 - 6 commits from branch
unmarked as a Work In Progress
changed title from WIP: (fix): Play videos within activity if not canary to [Sprint/LuckyLizard](fix): Play videos within activity if not canary
changed the description
- Owner
placed on rubbersoul for testing
- Last updated by Olivia Madrid
181 181 class: 'm-overlayModal--media' 182 182 }).present(); 183 183 } else { 184 this.router.navigate([`/media/${this.activity.entity_guid}`]); 184 if (this.activity.custom_type !== 'video'){ - Developer
Only minor but the bracket at the end of this line needs a space char before it
changed this line in version 5 of the diff
- Last updated by Olivia Madrid
392 398 } 393 399 394 400 requestMediaModal() { 395 if (!this.canPlayThrough) { 401 if (!this.metadataLoaded) { 396 402 return; 397 403 } 398 404 399 if (this.isModal) { 405 let isMediaPage = false; 406 if (!this.isModal && !this.isActivity){ - Developer
Another over here
changed this line in version 5 of the diff
approved this merge request
- Developer
https://screencast.com/t/Sm9n4WWUDS
Video showing two issues I found.
First is the embedded videos in reminds still go to galleries
The other is double clicks on youtube videos