Feat/closed channels 602
1/5 threads resolved
changed milestone to %sprint: Lucky Lizard
added Squad::Green scoped label
added 14 commits
- ed5c797d - Sprint/KiltedKoala: Added in wire transaction e2e test #1641 (closed)
- bfd7f8ed - Merge branch 'feat/wire-e2e-1641' into 'master'
- fa9d8d65 - Sprint/KiltedKoala: Added in comment-tree e2e tests #1635 (closed)
- c55bb642 - Merge branch 'feat/comment-tree-e2e-1635' into 'master'
- 30f6bcee - Sprint/KiltedKoala: Added e2e tests for onboarding #1639 (closed)
- c3300d5b - Merge branch 'feat/onboarding-e2e-1639' into 'master'
- 442c8ce9 - Sprint/KiltedKoala: Added e2e tests for boost impressions #1634 (closed)
- ef9383fc - Merge branch 'feat/boost-impressions-1634' into 'master'
- 3c09991d - Sprint/KiltedKoala: Added e2e test for boost rejection in console #1633 (closed)
- 39b6fcb6 - Merge branch 'feat/boost-console-e2e-1633' into 'master'
- e98051fe - Sprint/KiltedKoala: Added in e2e for addition and deletion of remind. #1637 (closed)
- 268165b1 - Merge branch 'feat/remind-e2e-1637' into 'master'
- caaf44dd - Merge remote-tracking branch 'origin/master' into feat/closed-channels-602
- c6dcfe5b - Optimizing e2e tests
Toggle commit listadded 4 commits
- 0d69d125 - Sprint/KiltedKoala: Media modal
- 13c6f471 - Merge branch 'feat/media-modal-1539' into 'master'
- 4d4b5217 - (chore): update media modal page
- 80b21460 - Merge remote-tracking branch 'origin/master' into feat/closed-channels-602
Toggle commit listadded 15 commits
- ce8f950a - (fix): Boost marketing hero overlay correctly positioned
- 99603881 - (fix): user's own avatar not blurry on newsfeed
- 12fd31a8 - (chore): Stop tooltip cutoff on referrals dashboard on mobile
- 9c57ecf8 - Merge branch 'chore/referral-tooltip-cutoff-1552' into 'master'
- c71e2be4 - Sprint/LuckyLizard: Changed ng test reporter for clearer output.
- 7806119a - Merge branch 'chore/change-test-reporter-1745' into 'master'
- c70ca1f0 - Merge branch 'fix/blurry-avatar-1746' into 'master'
- 7ba536e1 - Sprint/LuckyLizard: Removed redirect on failed password reset.
- 8f58bb2e - Merge branch 'fix/password-reset-725' into 'master'
- 4a15081e - Merge branch 'fix/boost-mkting-overlay-1733' into 'master'
- 0e26962a - Sprint/KiltedKoala: Fix/video pause on rotate #1418 (closed)
- e2eccb3a - Merge branch 'fix/video-pause-on-rotate-1418' into 'master'
- d52600d6 - Merge remote-tracking branch 'origin/master' into feat/closed-channels-602
- 497547a4 - Merge branch 'feat/closed-channels-602' of gitlab.com:minds/front into feat/closed-channels-602
- 2ed394f1 - Everything working edition
Toggle commit listadded 1 commit
- fbfe9770 - Added our project id to cypress. Removed timeouts
added 5 commits
- 37ac7b64 - (rollback): Regression created where newsfeeds blow up - #1766
- ec161448 - (feat): sentry for angular
- 2a24666e - (fix): do not throw error for missing entity, log in console
- 0cafd414 - Merge remote-tracking branch 'origin/master' into feat/closed-channels-602
- 324b0ded - Electron hates our file upload workaround. The npm package that addresses that...
Toggle commit list- Last updated by Brian Hatchet
36 36 "production": { 37 37 "optimization": true, 38 38 "outputHashing": "all", 39 "sourceMap": false, 39 "sourceMap": { 40 "hidden": true, 41 "scripts": true, 42 "styles": true 43 }, - Developer
Not essential but bracket alignment is a little messed up here.
changed this line in version 17 of the diff
31 37 32 38 cy.get('.m-groups-save > button').contains('Create').click(); 33 39 34 cy.wait(1000); - Developer
Is this one essential? Happy to approve but could cause occasional test flaking in a small percentile of runs.
- Resolved by Brian Hatchet
- Last updated by Ben Hayward
58 cy.get(commentButton).click(); 59 60 //Add the first level of comments 61 cy.get(commentInput).type(testMessage[1]); 62 cy.get(postCommentButton).click(); 63 cy.get(commentContent).contains(testMessage[1]); 64 65 //Add the second level of comments 66 cy.get(replyButton).click(); 67 cy.get(commentInput) 68 .first() 69 .type(testMessage[2]); 70 cy.get(postCommentButton) 71 .first() 72 .click(); 73 cy.get(commentContent).contains(testMessage[2]) - Developer
formatting here, no semi-colon.
- Developer
This is likely my code
added 5 commits
- 706414c8...6a48c5b1 - 4 commits from branch
epic/permissions-open-channels
- 1c983fd9 - Merge remote-tracking branch 'origin/master' into feat/closed-channels-602
- 706414c8...6a48c5b1 - 4 commits from branch
1 1 .m-overlay-modal { 2 position: fixed; 3 right: 2vw; 4 left: 2vw; 5 margin: auto; 6 z-index: 9999999; 7 8 top: 50%; 9 max-height: 98vh; 2 &:not(.m-overlayModal--media) { 3 position: fixed; 4 right: 2vw; - Developer
Probably nothing to be concerned about, but just to check have you tested this in Safari? I've had major headaches in the past with it and vw/vh.