(fix) adapt code to reviews

Controllers/api/v1/blog.php

@@ -290,7 +290,7 @@ class blog implements Interfaces\Api
 
  
  if (isset($_POST['time_created'])) {
- $timeCreatedDelegate = new Core\Feeds\Activity\Delegates\TimeCreatedDelegate();
+ $timeCreatedDelegate = new Core\Blogs\Delegates\TimeCreatedDelegate();
 
  if ($editing) {
  $timeCreatedDelegate->onUpdate($blog, $_POST['time_created'], time());

Core/Blogs/Delegates/TimeCreatedDelegate.php

+<?php
+/**
+ * TimeCreatedDelegate
+ * @author juanmsolaro
+ */
+
+namespace Minds\Core\Blogs\Delegates;
+
+use Minds\Core\Feeds\Scheduled\EntityTimeCreated;
+
+class TimeCreatedDelegate
+{
+
+ /** @var Core\Feeds\Scheduled\EntityTimeCreated $entityTimeCreated */
+ protected $entityTimeCreated;
+
+ /**
+ * TimeCreatedDelegate constructor.
+ * @param Save $save
+ */
+ public function __construct()
+ {
+ $this->entityTimeCreated = new EntityTimeCreated();
+ }
+
+ /**
+ * Validates time_created date and set it to activity
+ * @param $entity
+ * @param string $time_created
+ * @return bool
+ */
+ public function onAdd($entity, $time_created, $time_sent)
+ {
+ $this->entityTimeCreated->validate($entity, $time_created, $time_sent);
+ return true;
+ }
+
+ /**
+ * Validates time_created date and set it to activity
+ * @param $entity
+ * @param string $time_created
+ * @return bool
+ */
+ public function onUpdate($entity, $time_created, $time_sent)
+ {
+ $this->entityTimeCreated->validate($entity, $time_created, $time_sent);
+ return true;
+ }
+
+}

Core/Feeds/Activity/Delegates/TimeCreatedDelegate.php

@@ -6,25 +6,21 @@
 
 namespace Minds\Core\Feeds\Activity\Delegates;
 
-use Minds\Core\Di\Di;
-use Minds\Core\Entities\Actions\Save;
-use Minds\Entities\Activity;
+use Minds\Core\Feeds\Scheduled\EntityTimeCreated;
 
 class TimeCreatedDelegate
 {
 
- /** @var Save */
- protected $save;
+ /** @var Core\Feeds\Scheduled\EntityTimeCreated $entityTimeCreated */
+ protected $entityTimeCreated;
 
  /**
  * TimeCreatedDelegate constructor.
  * @param Save $save
  */
- public function __construct(
- $save = null
- )
+ public function __construct()
  {
- $this->save = $save ?: new Save();
+ $this->entityTimeCreated = new EntityTimeCreated();
  }
 
  /**
@@ -35,7 +31,7 @@ class TimeCreatedDelegate
  */
  public function onAdd($entity, $time_created, $time_sent)
  {
- $this->validate($entity, $time_created, $time_sent);
+ $this->entityTimeCreated->validate($entity, $time_created, $time_sent);
  return true;
  }
 
@@ -47,23 +43,8 @@ class TimeCreatedDelegate
  */
  public function onUpdate($entity, $time_created, $time_sent)
  {
- $this->validate($entity, $time_created, $time_sent);
+ $this->entityTimeCreated->validate($entity, $time_created, $time_sent);
  return true;
  }
 
-
- private function validate($entity, $time_created, $time_sent)
- {
- if ($time_created > strtotime('+3 Months')) {
- throw new \InvalidParameterException();
- }
-
- if ($time_created < strtotime('+5 Minutes')) {
- $time_created = $time_sent;
- }
-
- $entity->setTimeCreated($time_created);
- $entity->setTimeSent($time_sent);
- }
-
 }

Core/Feeds/Scheduled/EntityTimeCreated.php

+<?php
+
+namespace Minds\Core\Feeds\Scheduled;
+
+class EntityTimeCreated
+{
+ /**
+ * EntityTimeCreated constructor.
+ * 
+ */
+ public function __construct()
+ {
+
+ }
+
+ public function validate($entity, $time_created, $time_sent)
+ {
+ if ($time_created > strtotime('+3 Months')) {
+ throw new \InvalidParameterException();
+ }
+
+ if ($time_created < strtotime('+5 Minutes')) {
+ $time_created = $time_sent;
+ }
+
+ $entity->setTimeCreated($time_created);
+ $entity->setTimeSent($time_sent);
+ }
+}
\ No newline at end of file