Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Mobile
Minds Mobile
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 188
    • Issues 188
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • Minds
  • Minds MobileMinds Mobile
  • Merge Requests
  • !306

Merged
Opened 1 week ago by Martin Santangelo@msantang78
  • Report abuse
Report abuse

[Sprint/LuckyLizard] (feat) remember hashtag on/off value

closes #1176

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b feat/store-hastags-preferred-value origin/feat/store-hastags-preferred-value

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/release/3.9.0
git merge --no-ff feat/store-hastags-preferred-value

Step 4. Push the result of the merge to GitLab

git push origin release/3.9.0

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge feat/store-hastags-preferred-value into release/3.9.0
  • Email patches
  • Plain diff
Could not retrieve the pipeline status. For troubleshooting steps, read the documentation.
Merge request approved. Approved by
Brian Hatchet
Brian Hatchet
Emiliano Balbuena
Emiliano Balbuena

Merged by Martin Santangelo 9 hours ago

The changes were merged into release/3.9.0 with 350e49c0

Pipeline #77894860 passed with warnings for 350e49c0 on release/3.9.0
          • Discussion 3
          • Commits 1
          • Pipelines 1
          • Changes 3
          0/1 thread resolved
          • Loading...
          • Martin Santangelo @msantang78 changed milestone to %sprint: Lucky Lizard 1 week ago

            changed milestone to %sprint: Lucky Lizard

          • Martin Santangelo @msantang78 added MR::Awaiting Review Squad::Green scoped labels 1 week ago

            added MR::Awaiting Review Squad::Green scoped labels

          • Brian Hatchet
            Brian Hatchet :speech_balloon: @brianhatchet started a thread on the diff 1 week ago
            Last updated by Martin Santangelo 6 days ago
            src/settings/SettingsStore.js
            20 22 */
            21 23 @action.bound
            22 24 async init() {
            23 const data = await storageService.multiGet(['LeftHanded', 'AppLog', 'CreatorNsfw', 'ConsumerNsfw']);
            25 const data = await storageService.multiGet(['LeftHanded', 'AppLog', 'CreatorNsfw', 'ConsumerNsfw', 'UseHashtags']);
            24 26 if (!data) return;
            25 27 this.leftHanded = data[0][1];
            26 28 this.appLog = data[1][1];
            27 29 this.creatorNsfw = data[2][1] || [];
            28 30 this.consumerNsfw = data[3][1] || [];
            • Brian Hatchet
              Brian Hatchet :speech_balloon: @brianhatchet · 1 week ago
              Developer

              After reading the documentation of multiGet, I don't understand why we're getting with string keys and then reading the array with integers

              We should definitely being using constants to both store and retrieve data

              https://github.com/react-native-community/async-storage/blob/LEGACY/docs/API.md#multiGet

            • Brian Hatchet
              Brian Hatchet :speech_balloon: @brianhatchet · 6 days ago
              Developer

              Ping @msantang78

            • Martin Santangelo
              Martin Santangelo @msantang78 · 6 days ago
              Maintainer

              Because the result, as the multiGet doc says, is [ ['LeftHanded', 'somevalue'], ['AppLog', 'somevalue']....]

              if I want to retrieve one particular result using the key I need to do something like:

              this.leftHanded = result.find(r => r[0] == 'LeftHanded');

              For every key

              Maybe I can map the result as an Object inside the StorageService.multiGet()

              So, instead of return an array with the format of the react-native's async-storage.multiGet, I can return something like

              {LeftHanded: value, AppLog: value, ... }

              Edited by Martin Santangelo 6 days ago
            • Please register or sign in to reply
          • Emiliano Balbuena @edgebal approved this merge request 11 hours ago

            approved this merge request

          • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 9 hours ago

            approved this merge request

          • Martin Santangelo @msantang78 merged 9 hours ago

            merged

          • Martin Santangelo @msantang78 mentioned in commit 350e49c0 9 hours ago

            mentioned in commit 350e49c0

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          sprint: Lucky Lizard
          Milestone
          sprint: Lucky Lizard
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Awaiting Review Squad::Green
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          3
          3 participants
          user avatar
          Martin Santangelo
          user avatar
          Brian Hatchet
          user avatar
          Emiliano Balbuena
          Reference: minds/mobile-native!306

          Revert this merge request

          This will create a new commit in order to revert the existing changes.

          Switch branch
          Cancel
          A new branch will be created in your fork and a new merge request will be started.

          Cherry-pick this merge request

          Switch branch
          Cancel
          A new branch will be created in your fork and a new merge request will be started.