[Sprint/KiltedKoala] (feat) scroll latest media in capture
closes #185
Request to merge feat/capture-image-scroll into release/3.9.0
The changes were merged into release/3.9.0 with 88a48bab
0/2 threads resolved
changed milestone to %sprint: Kilted Koala
added Squad::Green scoped label
added 22 commits
- eb546bf9...70354547 - 21 commits from branch
release/3.9.0 - 15c96e38 - Merge branch 'release/3.9.0' into feat/capture-image-scroll
- eb546bf9...70354547 - 21 commits from branch
Last updated by Martin Santangelo64 60 /** 65 61 * Load photos 66 62 */ 67 _loadPhotos() { 63 _loadPhotos = async() => { 64 65 if (this.state.loading || !this.state.hasMore) return; - Developer
We don't allow one line ifs without curly braces on the front end according to the tslint json. We should probably get consistent across our js code and turn this on in the eslintrc for mobile
MaintainerI agree, I usually don't use one line ifs, only with return sometimes. I will update that
changed this line in version 4 of the diff
- Last updated by Martin Santangelo
100 104 */ 101 105 render() { 102 106 103 const body = this.state.imagesLoaded ? 104 _.chunk(this.state.photos.map((p, i) => this.renderTile(p, i)), 3) 105 .map((c, i) => <View style={styles.row} key={i}>{c}</View>) 106 : <CenteredLoading /> 107 if (!this.state.imagesLoaded) return <CenteredLoading /> - Developer
Another inline if
changed this line in version 4 of the diff
- Developer
Ping @msantang78
Edited by Brian Hatchet approved this merge request
approved this merge request
mentioned in commit 88a48bab
merged
