Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 857
    • Issues 857
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 53
    • Merge Requests 53
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !501

Open
Opened 5 days ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/LuckyLizard](fix) Boost console feed #1596

Closes #1596

Try the create boost button for the different pages here https://fix-boost-console-feed-1596.minds.io/boost/console/newsfeed/create

Edited 38 minutes ago by Brian Hatchet

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix/boost-console-feed-1596 origin/fix/boost-console-feed-1596

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix/boost-console-feed-1596

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/boost-console-feed-1596 into master
The source branch is 31 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #77190166 passed with warnings for db32dcc9 on fix/boost-console-feed-1596
            Requires 2 more approvals from Devs and Deployers.
            Mark Harding
            Mark Harding
            Marcelo Rivera
            Marcelo Rivera
            Martin Santangelo
            Martin Santangelo
            Emiliano Balbuena
            Emiliano Balbuena
            Brian Hatchet
            Brian Hatchet
            Ready to be merged automatically. Ask someone with write access to this repository to merge this request

            Closes #1596

            Deletes source branch

            • Discussion 2
            • Commits 7
            • Pipelines 4
            • Changes 5
            0/1 thread resolved
            • Loading...
            • Ben Hayward @benhayward.ben added Squad::Green scoped label 5 days ago

              added Squad::Green scoped label

            • Ben Hayward @benhayward.ben added 1 commit 2 days ago

              added 1 commit

              • 3f7c0e7e - Fixed up tests and formatted

              Compare with previous version

            • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label 2 days ago

              added MR::Awaiting Review scoped label

            • Ben Hayward @benhayward.ben added 1 commit 2 days ago

              added 1 commit

              • db32dcc9 - Minor fix

              Compare with previous version

            • Mark Harding
              Mark Harding @markeharding started a thread on the diff 1 day ago
              src/app/modules/boost/console/booster/booster.component.ts
              59 .then((responses: any[]) => {
              60 this.loaded = true;
              61 this.inProgress = false;
              62
              63 this.posts = responses[0].activity || [];
              64 this.media = responses[1].entities || [];
              65 // this.posts = [];
              66 // this.media = [];
              67 this.loadComponent();
              68 })
              69 .catch(e => {
              70 this.inProgress = false;
              71 return false;
              72 });
              69 this.feedsService
              70 .setEndpoint(
              • Mark Harding
                Mark Harding @markeharding · 1 day ago
                Owner

                should this not be api/v2/feeds/container/${this.channel.guid}/${this.type}?

                Edited by Mark Harding 1 day ago
              • Please register or sign in to reply
            • Ben Hayward @benhayward.ben mentioned in issue #1596 1 day ago

              mentioned in issue #1596

            • Brian Hatchet :speech_balloon: @brianhatchet marked as a Work In Progress 51 minutes ago

              marked as a Work In Progress

            • Brian Hatchet :speech_balloon: @brianhatchet changed the description 51 minutes ago

              changed the description

            • Brian Hatchet :speech_balloon: @brianhatchet unmarked as a Work In Progress 38 minutes ago

              unmarked as a Work In Progress

            • Brian Hatchet
              Brian Hatchet :speech_balloon: @brianhatchet · 38 minutes ago
              Developer

              I tested this and it looks good. Once you address Mark's comment above, I will give it my approval.

              Edited by Brian Hatchet 37 minutes ago
            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
            Please register or sign in to reply
            0 Assignees
            None
            Assign to
            None
            Milestone
            None
            Assign milestone
            None
            Time tracking
            No estimate or time spent
            2
            Labels
            MR::Awaiting Review Squad::Green
            Assign labels
            • View project labels
            Lock merge request
            Unlocked
            9
            9 participants
            user avatar
            Mark Harding
            user avatar
            Marcelo Rivera
            user avatar
            Martin Santangelo
            user avatar
            Emiliano Balbuena
            user avatar
            Brian Hatchet
            user avatar
            Olivia Madrid
            user avatar
            Guy Thouret
            Reference: minds/front!501