Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 221
    • Issues 221
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 30
    • Merge Requests 30
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !288

Closed
Opened 3 weeks ago by Guy Thouret@gthouret
  • Report abuse
Report abuse

Fixes for various blocking and unblocking errors/warnings in dev environment

Fixes #661 (closed)

Includes fix for regression to Core\Entities.

It's not picked up all original changes so likely needs to revert the revert on master then merge this branch to get the last change.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b chore/661-misc-fixes origin/chore/661-misc-fixes

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff chore/661-misc-fixes

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge chore/661-misc-fixes into master
  • Email patches
  • Plain diff
Pipeline #73895500 passed with warnings for 189f6785 on chore/661-misc-fixes
          Requires 2 more approvals from Devs and Deployers.
          Mark Harding
          Mark Harding
          Rami Albatal
          Rami Albatal
          Ben Hayward
          Ben Hayward
          Marcelo Rivera
          Marcelo Rivera
          Martin Santangelo
          Martin Santangelo

          Closed by Guy Thouret 2 hours ago

          The changes were not merged into master

          Did not close #661 (closed)

          • Discussion 2
          • Commits 1
          • Pipelines 1
          • Changes 1
          • Loading...
          • Guy Thouret @gthouret added MR::Ready to Merge scoped label 3 weeks ago

            added MR::Ready to Merge scoped label

          • Mark Harding @markeharding approved this merge request 3 weeks ago

            approved this merge request

          • Mark Harding
            Mark Harding @markeharding · 3 weeks ago
            Owner

            @gthouret can you place back in your original changes? Also, are we sure the property check wasn't doing anything?

          • Mark Harding @markeharding added MR::Requires Changes Squad::Blue scoped labels and automatically removed MR::Ready to Merge label 3 weeks ago

            added MR::Requires Changes Squad::Blue scoped labels and automatically removed MR::Ready to Merge label

          • Mark Harding @markeharding unapproved this merge request 3 weeks ago

            unapproved this merge request

          • Mark Harding
            Mark Harding @markeharding · 1 day ago
            Owner

            @gthouret

          • Guy Thouret @gthouret closed 2 hours ago

            closed

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          0 Assignees
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Requires Changes Squad::Blue
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          8
          8 participants
          user avatar
          Mark Harding
          user avatar
          Rami Albatal
          user avatar
          Ben Hayward
          user avatar
          Marcelo Rivera
          user avatar
          Martin Santangelo
          user avatar
          Emiliano Balbuena
          user avatar
          Brian Hatchet
          Reference: minds/engine!288