Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 861
    • Issues 861
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 52
    • Merge Requests 52
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • List
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !510

Open
Opened 19 minutes ago by Olivia Madrid@omadrid
  • Report abuse
Report abuse

(fix): Play videos within activity if not canary

For non-canary users, clicking videos should play from the feed activity, not go to the media page. (Canary users go to media modal)

Closes #1761

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix/video-play-outside-canary-1761 origin/fix/video-play-outside-canary-1761

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix/video-play-outside-canary-1761

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/video-play-outside-canary-1761 into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #77670906 failed for a9df951b on fix/video-play-outside-canary-1761
            Requires 2 more approvals from Devs and Deployers.
            Guy Thouret
            Guy Thouret
            Marcelo Rivera
            Marcelo Rivera
            Martin Santangelo
            Martin Santangelo
            Mark Harding
            Mark Harding
            Ben Hayward
            Ben Hayward
            Ready to be merged automatically. Ask someone with write access to this repository to merge this request

            Closes #1761

            • Discussion 0
            • Commits 2
            • Pipelines 2
            • Changes 9
            • Loading...
            • Olivia Madrid @omadrid added 1 commit 7 minutes ago

              added 1 commit

              • a9df951b - (fix): import featuresServiceMock to pass tests

              Compare with previous version

            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
            Please register or sign in to reply
            0 Assignees
            None
            Assign to
            None
            Milestone
            None
            Assign milestone
            None
            Time tracking
            No estimate or time spent
            0
            Labels
            None
            Assign labels
            • View project labels
            Lock merge request
            Unlocked
            9
            9 participants
            user avatar
            Guy Thouret
            user avatar
            Marcelo Rivera
            user avatar
            Martin Santangelo
            user avatar
            Mark Harding
            user avatar
            Ben Hayward
            user avatar
            Emiliano Balbuena
            user avatar
            Juan Manuel Solaro
            Reference: minds/front!510