Skip to content

Minds Frontend
Minds Frontend
Open
Opened by Max Nurzia@mnurzia1
Report abuse

(wip) Sort selector fixes

I fixed the issues outlined in !472, namely the inconsistent margins across browsers and various instances of colors not being correct. Embarrassingly, I used a CSS feature that wasn't consistent across browsers, so while it looked fine on my Firefox it didn't render correctly in Chrome. Also included is a fix for the weird diff views. I had line endings set incorrectly and was pushing CR+LF instead of just LF. I fixed these here so that the changes getting merged are LF, which is consistent with the rest of the codebase.

Screenshots:

Firefox 68.0.2, desktop:

image

image

Chrome 76.0, desktop:

image

image

Firefox 68.0.2, mobile:

image

image

Chrome 76.0, mobile:

image

image

Request to merge mnurzia:sort-selector-rework into master
The source branch is 52 commits behind the target branch
Open in Web IDE
Pipeline #77628875 failed for c7ea9303 on mnurzia:sort-selector-rework
            Requires 2 more approvals from Devs and Deployers.
            Ready to be merged automatically. Ask someone with write access to this repository to merge this request
            Please register or sign in to reply