Skip to content

Minds Frontend
Minds Frontend
Merged
Opened by Olivia Madrid@omadrid22 of 22 tasks completed22/22 tasks
Report abuse

[Sprint/KiltedKoala](feat): Media modal

To do:

  • Click video thumbnail to open modal and autoplay
  • Get dimensions of video before modal dimensions are calculated
  • Allow vid progress bar seeker to work when hovering outside player
  • Video player styles
  • Move video controls outside player to fill modal width
  • Clean up a few variable/class names so they are meaningful
  • Resolve bug where newsfeed activity messages are doubled when you click on a modal
  • Media should continue to shrink along vertical axis after you hit the horiz axis min
  • Tablet - touch backdrop to close modal
  • Tablet - Fix overflow on vertical images in portrait orientation
  • Tablet - Fix faux url actually redirecting to media page
  • Tablet - handle video controls
  • Get img element height/width if not already in custom_data
  • Enable horizontal scrolling when window is smaller than modal
  • Replace screen dimensions with hardcoded min/max values
  • Fix failed tests
  • Fix reminded video failure
  • Make videos bigger than intrinsic size
  • Fix reminded images missing permalinks/comments
  • Add message/title content
  • Add feature flag
  • Don't allow click on unloaded video activity

Will close #1539 and #1600

Edited by Olivia Madrid
Request to merge feat/media-modal-1539 into master
Pipeline #77161100 passed with warnings for bb7450e4 on feat/media-modal-1539
            Merge request approved. Approved by
            Mark Harding

            Merged by Mark Harding

            The changes were merged into master with 13c6f471

            The source branch has been deleted

            Mentions #1539 and #1600

            Pipeline #77255390 canceled for 13c6f471 on master
                          0/1 thread resolved
                          Please register or sign in to reply